Skip to content

fix(k8s): fix validation kubernetes-resource snippet #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmalek wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −8
Open

fix(k8s): fix validation kubernetes-resource snippet #3606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/_how-tos/operator-get-started-hybrid-deploy-dataplane.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ spec:

## Check the Ready status

If the `DataPlane` has `Ready` condition set to `True` then you can visit {{site.konnect_short_name}} and see the dataplane in the list of connected Data Planes for your Control Plane:

<!-- vale off -->
{% validation kubernetes-resource %}
kind: dataplane
kind: DataPlane
name: dataplane-example
conditionType: Ready
reason: Ready
{% endvalidation %}
<!-- vale on -->

If the `DataPlane` has `Ready` condition set to `True` then you can visit {{site.konnect_short_name}} and see the dataplane in the list of connected Data Planes for your Control Plane.
3 changes: 1 addition & 2 deletions app/_how-tos/operator-konnect-getstarted-ratelimiting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ data:
{% endentity_example %}
<!-- vale on -->


## Deploy a Data Plane

Apply a `DataPlane` resource to deploy a {{site.base_gateway}} instance that connects to your {{site.konnect_short_name}} Control Plane:
Expand Down Expand Up @@ -116,4 +115,4 @@ iterations: 6
url: '/anything'
on_prem_url: $PROXY_IP
konnect_url: $PROXY_IP
{% endvalidation %}
{% endvalidation %}
3 changes: 0 additions & 3 deletions app/_includes/how-tos/validations/kubernetes-resource/snippet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
Check that `{{ include.config.type }}` is `{{ include.config.status }}` on the `{{ include.config.name }}` resource:

{% assign name = include.config.name %}
{% assign kind = include.config.kind %}
{% assign conditionType = include.config.conditionType | default: "Programmed" %}
Expand All @@ -10,7 +8,6 @@ Check that `{{ include.config.type }}` is `{{ include.config.status }}` on the `
You can verify the `{{ kind }}` was reconciled successfully by checking its `{{ conditionType }}` condition.
{% endunless %}


```bash
kubectl get {% if include.config.namespace %}-n {{ include.config.namespace }} {% endif %}{{ kind | downcase }} {{ name }} \
-o=jsonpath='{.status.conditions[?(@.type=="{{ conditionType }}")]}' | jq
Expand Down
Loading