-
Notifications
You must be signed in to change notification settings - Fork 612
Feat: Custom plugin streaming #8556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions, but overall, this looks great! I think we can remove the UI instructions if no one asked for them specifically.
app/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins.md
Outdated
Show resolved
Hide resolved
app/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins.md
Outdated
Show resolved
Hide resolved
app/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins.md
Outdated
Show resolved
Hide resolved
app/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins.md
Outdated
Show resolved
Hide resolved
app/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins.md
Outdated
Show resolved
Hide resolved
> **Note**: For adding custom plugins to a Dedicated Cloud Gateway, see | ||
[Custom plugins in Dedicated Cloud Gateways](/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have: for Dev site, I think the DCG custom plugin section could be an include that we'd use here instead of the note. But I think the way you have it now it okay for this release.
Co-authored-by: Diana <[email protected]>
app/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins.md
Outdated
Show resolved
Hide resolved
@cloudjumpercat I added just one line about the UI: https://github.com/Kong/docs.konghq.com/pull/8556/files#diff-c95c75b11ab7a5175cccb8198f5c1768c276af88e0609783e97bbf9c7751ac60R28 Hopefully that'll get ahead of any concerns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Docs for custom plugin streaming on DCGWs.
Testing instructions
Preview link: https://deploy-preview-8556--kongdocs.netlify.app/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins/
Checklist