Skip to content

Feat: Custom plugin streaming #8556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025
Merged

Feat: Custom plugin streaming #8556

merged 8 commits into from
Apr 23, 2025

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Mar 13, 2025

Description

Docs for custom plugin streaming on DCGWs.

Testing instructions

Preview link: https://deploy-preview-8556--kongdocs.netlify.app/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins/

Checklist

@lena-larionova lena-larionova added the review:copyedit Request for writer review. label Mar 13, 2025
@lena-larionova lena-larionova requested a review from a team as a code owner March 13, 2025 21:04
@lena-larionova lena-larionova added this to the Gateway 3.10 milestone Mar 13, 2025
Copy link

netlify bot commented Mar 13, 2025

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 552914c
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/68092b863055120008ca0e7e
😎 Deploy Preview https://deploy-preview-8556--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 91 (🟢 up 7 from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudjumpercat cloudjumpercat self-requested a review March 14, 2025 14:02
Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions, but overall, this looks great! I think we can remove the UI instructions if no one asked for them specifically.

Comment on lines +20 to +21
> **Note**: For adding custom plugins to a Dedicated Cloud Gateway, see
[Custom plugins in Dedicated Cloud Gateways](/konnect/gateway-manager/dedicated-cloud-gateways/custom-plugins/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have: for Dev site, I think the DCG custom plugin section could be an include that we'd use here instead of the note. But I think the way you have it now it okay for this release.

@lena-larionova
Copy link
Contributor Author

@cloudjumpercat I added just one line about the UI: https://github.com/Kong/docs.konghq.com/pull/8556/files#diff-c95c75b11ab7a5175cccb8198f5c1768c276af88e0609783e97bbf9c7751ac60R28

Hopefully that'll get ahead of any concerns.

Copy link
Contributor

@cloudjumpercat cloudjumpercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lena-larionova lena-larionova added the do not merge Issues/ PRs whose changes should not be merged at this time label Mar 14, 2025
@lena-larionova lena-larionova removed the do not merge Issues/ PRs whose changes should not be merged at this time label Mar 27, 2025
@josh-konghq josh-konghq merged commit 859e51f into main Apr 23, 2025
12 of 13 checks passed
@josh-konghq josh-konghq deleted the dcg-plugin-streaming branch April 23, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:copyedit Request for writer review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants