Add cli and pdk docs #8562
Open
Add cli and pdk docs #8562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianrbz
added
the
review:autodoc
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lena-larionova
requested changes
Mar 14, 2025
There was a problem hiding this comment.
This shouldn't be getting removed from the nav, both of these PDK modules still exist - they're just in a different folder, but the generator doesn't know that: https://github.com/Kong/kong-ee/blob/master/kong/enterprise_edition/pdk/websocket.lua
Comment on lines
+322
to
+325
| {% if_version lte:3.9.x %} | ||
| --v verbose | ||
| --vv debug | ||
| {% endif_version %} |
There was a problem hiding this comment.
Suggested change
| {% if_version lte:3.9.x %} | |
| --v verbose | |
| --vv debug | |
| {% endif_version %} | |
| --v verbose | |
| --vv debug |
Why would this be removed? I checked the CLI in 3.10.0.0-rc.2, both of these flags are still here.
Comment on lines
+454
to
+458
| {% if_version gte:3.10.x %} | ||
| Usage: kong runner file.lua [args] | ||
| {% else %} | ||
| Usage: kong runner [file] [args] | ||
| {% endif_version %} |
There was a problem hiding this comment.
Suggested change
| {% if_version gte:3.10.x %} | |
| Usage: kong runner file.lua [args] | |
| {% else %} | |
| Usage: kong runner [file] [args] | |
| {% endif_version %} | |
| Usage: kong runner file.lua [args] |
This just looks like a clarification fix, doesn't seem like it needs to be version-tagged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://konghq.atlassian.net/browse/DOCU-4207
https://konghq.atlassian.net/browse/DOCU-4206
Testing instructions
Preview link:
Checklist