Skip to content

ci: update workflow to use ubuntu-24.04-arm for tests #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fahedouch
Copy link

@fahedouch fahedouch commented Feb 25, 2025

What this PR does / why we need it:

GHA now provides ARM runners for free

https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

Which issue this PR fixes

  • set the runner version to avoid unexpected breaking changes
  • trying to accelerate GHA CI

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@fahedouch fahedouch requested a review from a team as a code owner February 25, 2025 15:45
@fahedouch fahedouch changed the title ci: update workflow to use ubuntu-24.04-arm for all jobs ci: update workflow to use ubuntu-24.04-arm for tests Feb 25, 2025
@fahedouch
Copy link
Author

Hi Folks, need CI workflows approval to validate my changes please :)

@pmalek
Copy link
Member

pmalek commented Feb 28, 2025

Hi @fahedouch,

Thanks for the PR. This is quite nice and we'd definitely want to leverage that (at some point). I'm worried though that this will require a bit more work as:

  • We don't just want to change to ARM environment in each workflow. Most likely we'd like to leverage both arm64 and x86_64 in build and/or test workflows.
  • The docker build workflows might need some adjustments as I believe they have been relying on the fact that they run on x86_64 and emulate arm64 in build

There might be more that I'm not aware of as of now but these should be enough to pause and consider how we'd like to leverage that capability.

@fahedouch
Copy link
Author

fahedouch commented Mar 3, 2025

Hi @pmalek,

thank you for your feedback.

Most likely we'd like to leverage both arm64 and x86_64 in build and/or test workflows.

The docker build workflows might need some adjustments as I believe they have been relying on the fact that they run on x86_64 and emulate arm64 in build

LGTM for both architectures. I suggest enabling double architecture just for test workflows for the moment, just to see the behavior, and then expanding the scope for the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants