fix: apply Ingress service name for DP #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao12345666333
force-pushed
the
add-ingress-service-name
branch
3 times, most recently
from
aea848f to
33e190e
Compare
tao12345666333
force-pushed
the
add-ingress-service-name
branch
from
33e190e to
26e7951
Compare
pmalek
reviewed
Apr 17, 2025
Signed-off-by: Jintao Zhang <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
Signed-off-by: Jintao Zhang <[email protected]>
tao12345666333
force-pushed
the
add-ingress-service-name
branch
from
3889a1c to
e1d714f
Compare
randmonkey
approved these changes
Apr 18, 2025
pmalek
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When a Gateway is created with a GatewayConfiguration that specifies a service name for the ingress service, that name is not being applied to the DataPlane that gets created. This is because the
gatewayConfigDataPlaneOptionsToDataPlaneOptionsfunction incontroller/gateway/controller_reconciler_utils.gois not copying theNamefield from the GatewayConfiguration to the DataPlane.Which issue this PR fixes
Fixes #1411
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes