feat: Added Konnect Workspace related changes by shivaygupta-dotcom · Pull Request #376 · Kong/go-database-reconciler

shivaygupta-dotcom · 2026-02-18T06:59:09Z

Summary

We need to support Workspaces in Konnect.
more context: https://konghq.atlassian.net/browse/KOKO-3141

Full changelog

Added new field workspacename in KonnectConfig struct.
Added a helper func KonnectWorkspaceExists to check if workspace exists in Konnect.
Added changes in GetDefaulter to handle workspace case for konnect using above helper func.

Issues resolved

Documentation

Link to the website documentation PR

Testing

Unit tests
E2E tests
Manual testing on Universal
Manual testing on Kubernetes

codecov-commenter · 2026-02-18T07:12:30Z

Codecov Report

❌ Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.79%. Comparing base (a02660e) to head (8f3597b).

Files with missing lines	Patch %	Lines
pkg/utils/utils.go	0.00%	7 Missing ⚠️
pkg/utils/defaulter.go	40.00%	4 Missing and 2 partials ⚠️
pkg/diff/diff.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   28.80%   28.79%   -0.02%     
==========================================
  Files         121      121              
  Lines       16480    16498      +18     
==========================================
+ Hits         4747     4750       +3     
- Misses      11116    11130      +14     
- Partials      617      618       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…onnect

gitguardian · 2026-03-10T04:36:12Z

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
27577943	Triggered	Generic High Entropy Secret	`894aafa`	tests/integration/testdata/dump/001-entities-with-tags/expected312.yaml	View secret
27577921	Triggered	Generic Private Key	`894aafa`	tests/integration/testdata/dump/001-entities-with-tags/expected312.yaml	View secret
27577938	Triggered	Generic High Entropy Secret	`894aafa`	tests/integration/testdata/dump/001-entities-with-tags/expected312.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

…kspaces and commented some entites for time being, will revert back once APIs are avialable.

Prashansa-K · 2026-03-13T07:03:04Z

pkg/utils/utils.go

 	"of the updated configuration file before applying\n" +
 	"the configuration in production. Incorrect changes will result in\n" +
 	"unintended traffic routing by Kong Gateway.\n\n" +
-


Why this removal?

oh sorry, by mistake. I did bit of formatting and it got removed by IDE. I am reverting.

Prashansa-K · 2026-03-13T07:03:14Z

pkg/utils/tags_test.go

 		return false
 	}
-	for i := 0; i < len(want); i++ {
+	for i := range want {


What are we doing here?

I got linter error as slice index out of range, because while accessing have slice inside below for loop
for i := 0; i < len(want); i++ , we didn't had any check and linter was assuming that it might cause nil pointer dereference.
So added a fix, for the same.

Prashansa-K · 2026-03-13T07:03:36Z

go.mod

 	github.com/hexops/gotextdiff v1.0.3
-	github.com/kong/deck v1.56.0
-	github.com/kong/go-kong v0.72.1
+	github.com/kong/deck v1.55.1


Why would you downgrade deck version?

Actually, when I am adding go-kong changes ref here it is automatically downgrading decK version.

Prashansa-K · 2026-03-13T07:06:23Z

pkg/utils/utils.go

+	if workspace == "" {
+		return true, nil
+	}
+	return client.Workspaces.ExistsByName(ctx, &workspace)


Why are we using ExistsByName() here and not just Exists() like in the above function?

For checking workspace existence, the endpoints are different:
• In Kong, the endpoint is /%v/workspaces/%v
• In Konnect, the endpoint is /workspaces/%s
Due to this difference, the handling needs to be separate. I added this logic in the existsByName function. Since workspaceExists in decK already uses existsByName, I am using existsByName here instead of exists to ensure the Konnect flow works correctly.

Prashansa-K · 2026-03-13T07:07:53Z

pkg/utils/defaulter.go

+	var exists bool
+	var err error
+	if opts.IsKonnect {
+		exists, err = KonnectWorkspaceExists(ctx, opts.Client)


Why do we need a separate utility if both utilities work almost similarly?

What's the difference between client.Workspaces.ExistsByName(ctx, &workspace) and client.Workspaces.Exists(ctx, &workspace)? Why can't Konnect use the existing utility?

While creating a request for Kong, the NewRequest method appends the workspace name to the base endpoint. This behavior is not required for Konnect. Because of this difference, I implemented a separate utility function called NewKonnectWorkspaceRequest.

For checking workspace existence, the endpoints are also different:
• In Kong, the endpoint is /%v/workspaces/%v
• In Konnect, the endpoint is /workspaces/%s
Due to this difference, the handling needs to be separate. I added this logic in the existsByName function. Since workspaceExists in decK already uses existsByName, I am using existsByName here instead of exists to ensure the Konnect flow works correctly.

Apologies for not adding this in description.

shivaygupta-dotcom requested a review from Prashansa-K February 18, 2026 06:59

shivaygupta-dotcom removed the request for review from Prashansa-K February 19, 2026 06:27

feat: Added WorkspaceName in KonnectConfig to support workspaces in k…

6c6554e

…onnect

shivaygupta-dotcom force-pushed the feature/KOKO-3141-konnect-workspace branch from 7d8a887 to 6c6554e Compare February 21, 2026 03:49

Merge branch 'main' into feature/KOKO-3141-konnect-workspace

894aafa

feat: Added changes to support isKonnect flag across the flow for wor…

4580549

…kspaces and commented some entites for time being, will revert back once APIs are avialable.

shivaygupta-dotcom mentioned this pull request Mar 11, 2026

feat: Added changes to support konnect workspace APIs Kong/go-kong#602

Merged

feat: refactored some code and fixed lint issues

67939bb

shivaygupta-dotcom force-pushed the feature/KOKO-3141-konnect-workspace branch from e3cf73f to 67939bb Compare March 11, 2026 11:09

shivaygupta-dotcom requested a review from Prashansa-K March 11, 2026 11:37

feat: Added updated configuration of Go-Kong

c283e54

shivaygupta-dotcom changed the title ~~feat: Added WorkspaceName and ControlPlaneId in KonnectConfig~~ feat: Added Konnect Workspace related changes Mar 12, 2026

shivaygupta-dotcom mentioned this pull request Mar 12, 2026

feat: Added changes to support workspace with konnect flow Kong/deck#1892

Open

feat: update few dependencies to latest

49df7fc

Prashansa-K reviewed Mar 13, 2026

View reviewed changes

shivaygupta-dotcom added 2 commits March 13, 2026 14:10

feat: refactored few conditions and resolved review comment.

07c1de9

feat: resolved review comment.

8f3597b

shivaygupta-dotcom requested a review from Prashansa-K March 13, 2026 09:07

shivaygupta-dotcom mentioned this pull request Mar 13, 2026

feat: Added changes to support crud for graphql-cost-decoration custo… #428

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Added Konnect Workspace related changes#376

feat: Added Konnect Workspace related changes#376
shivaygupta-dotcom wants to merge 8 commits intomainfrom
feature/KOKO-3141-konnect-workspace

shivaygupta-dotcom commented Feb 18, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Feb 18, 2026 •

edited

Loading

Uh oh!

gitguardian bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Prashansa-K Mar 13, 2026

Uh oh!

shivaygupta-dotcom Mar 13, 2026 •

edited

Loading

Uh oh!

Prashansa-K Mar 13, 2026

Uh oh!

shivaygupta-dotcom Mar 13, 2026 •

edited

Loading

Uh oh!

Prashansa-K Mar 13, 2026

Uh oh!

shivaygupta-dotcom Mar 13, 2026

Uh oh!

Prashansa-K Mar 13, 2026

Uh oh!

shivaygupta-dotcom Mar 13, 2026

Uh oh!

Prashansa-K Mar 13, 2026

Uh oh!

shivaygupta-dotcom Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

shivaygupta-dotcom commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Full changelog

Issues resolved

Documentation

Testing

Uh oh!

codecov-commenter commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gitguardian bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shivaygupta-dotcom Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shivaygupta-dotcom Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shivaygupta-dotcom commented Feb 18, 2026 •

edited

Loading

codecov-commenter commented Feb 18, 2026 •

edited

Loading

gitguardian bot commented Mar 10, 2026 •

edited

Loading

shivaygupta-dotcom Mar 13, 2026 •

edited

Loading

shivaygupta-dotcom Mar 13, 2026 •

edited

Loading