fix: setting konnect flag before concurrent handling#459
Merged
shivaygupta-dotcom merged 1 commit intomainfrom Apr 22, 2026
Merged
fix: setting konnect flag before concurrent handling#459shivaygupta-dotcom merged 1 commit intomainfrom
shivaygupta-dotcom merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 28.40% 28.40% -0.01%
==========================================
Files 123 123
Lines 20722 20726 +4
==========================================
Hits 5887 5887
- Misses 14204 14208 +4
Partials 631 631 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prashansa-K
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is successor of attached PR: #428
Summary
https://github.com/Kong/deck/actions/runs/24771118558/job/72477519286
This PR fixes a data race which we got on above run of apply test from decK.
The
SetKonnectFlagflag was previously being accessed and modified across goroutines, which made it unsafe. To address this,SetKonnectFlagis now executed once upfront, before any goroutines are spawned.Additionally, graphqlRateLimitingCostDecorationCRUD.Delete has been updated to rely on a precomputed isKonnect field instead of calling IsKonnectMode() at runtime. This brings it in line with how other CRUD implementations already handle the same logic, and avoids repeated access to shared state.
Full changelog
Issues resolved
Fix #XXX
Documentation
Testing