Skip to content

feat: Added CreateWithID func and test for graphql_rate_limiting_cost…#605

Closed
shivaygupta-dotcom wants to merge 0 commit intomainfrom
feature/decK-1909
Closed

feat: Added CreateWithID func and test for graphql_rate_limiting_cost…#605
shivaygupta-dotcom wants to merge 0 commit intomainfrom
feature/decK-1909

Conversation

@shivaygupta-dotcom
Copy link
Contributor

@shivaygupta-dotcom shivaygupta-dotcom commented Mar 12, 2026

https://konghq.atlassian.net/browse/FTI-7307
Kong/deck#1909

Summary:

  1. Added CRUD support for GraphQL Rate Limiting Advanced cost decorators in decK.
  2. Introduced a new method CreateWithID in AbstractGraphqlRateLimitingCostDecorationService to allow creating CostDecoration entities in Kong with a specified ID.
  3. This change was required because the existing Create method does not allow specifying an ID, whereas decK supports user-defined IDs during resource creation.

@shivaygupta-dotcom shivaygupta-dotcom requested review from a team as code owners March 12, 2026 11:11
@shivaygupta-dotcom
Copy link
Contributor Author

shivaygupta-dotcom commented Mar 12, 2026

CI failures had already been fixed in below 2 PRs.
#604
#602

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.15%. Comparing base (8263d16) to head (eb4629d).

Files with missing lines Patch % Lines
...g/graphql_rate_limiting_cost_decoration_service.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   59.71%   60.15%   +0.44%     
==========================================
  Files          74       74              
  Lines        5116     5128      +12     
==========================================
+ Hits         3055     3085      +30     
+ Misses       1403     1385      -18     
  Partials      658      658              
Flag Coverage Δ
3.10.0.0 56.80% <66.66%> (?)
3.10.0.1 56.84% <66.66%> (?)
3.10.0.2 56.80% <66.66%> (?)
3.10.0.5 54.50% <66.66%> (?)
3.10.0.6 56.88% <66.66%> (?)
3.11.0.0 54.66% <66.66%> (?)
3.11.0.3 56.68% <66.66%> (?)
3.11.0.5 54.66% <66.66%> (?)
3.11.0.7 56.64% <66.66%> (?)
3.12.0.0 56.25% <66.66%> (?)
3.12.0.1 54.23% <66.66%> (?)
3.12.0.2 54.23% <66.66%> (?)
3.12.0.3 ?
3.13.0.0 55.30% <66.66%> (+2.05%) ⬆️
3.13.0.1 55.30% <66.66%> (?)
3.4 41.26% <0.00%> (+2.36%) ⬆️
3.4.0.0 54.11% <66.66%> (?)
3.4.1.0 54.07% <66.66%> (?)
3.4.3.10 54.07% <66.66%> (?)
3.4.3.12 54.11% <66.66%> (?)
3.4.3.14 51.77% <66.66%> (?)
3.4.3.17 54.07% <66.66%> (?)
3.4.3.18 51.77% <66.66%> (?)
3.4.3.19 ?
3.4.3.20 54.07% <66.66%> (?)
3.4.3.21 54.07% <66.66%> (?)
3.4.3.23 54.07% <66.66%> (?)
3.4.3.3 54.11% <66.66%> (+0.06%) ⬆️
3.4.3.4 54.11% <66.66%> (?)
3.4.3.6 54.07% <66.66%> (?)
3.4.3.7 54.11% <66.66%> (?)
community 41.26% <0.00%> (+2.36%) ⬆️
enterprise 58.79% <66.66%> (+0.44%) ⬆️
integration 60.15% <66.66%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shivaygupta-dotcom shivaygupta-dotcom changed the base branch from main to fix/ci-fix March 12, 2026 14:55
Base automatically changed from fix/ci-fix to main March 13, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants