Skip to content

fix: make grpc reflection consist with proto import #10192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CurryYangxx wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −1
Draft

fix: make grpc reflection consist with proto import #10192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/insomnia/src/main/ipc/grpc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ const getMethodsFromReflectionServer = async (
}
const packageDefinition = protoLoader.loadFileDescriptorSetFromBuffer(
Buffer.from(res.fileDescriptorSet.toBinary()),
grpcOptions,
);
for (const definition of Object.values(packageDefinition)) {
const serviceDefinition = asServiceDefinition(definition);
Expand Down Expand Up @@ -245,7 +246,7 @@ const getMethodsFromReflection = async (
const fullService = fileContainingSymbol.lookupService(service);
const mockedRequestMethods = mockRequestMethods(fullService);
const descriptorMessage = fileContainingSymbol.toDescriptor('proto3');
const packageDefinition = protoLoader.loadFileDescriptorSetFromObject(descriptorMessage, {});
const packageDefinition = protoLoader.loadFileDescriptorSetFromObject(descriptorMessage, grpcOptions);
const tryToGetMethods = () => {
try {
console.log('[grpc] loading service from reflection:', service);
Expand Down
Loading