Hybrid Gateway conformance: enable HTTPRouteSimpleSameNamespace test#3522
Draft
tao12345666333 wants to merge 2 commits intomainfrom
Draft
Hybrid Gateway conformance: enable HTTPRouteSimpleSameNamespace test#3522tao12345666333 wants to merge 2 commits intomainfrom
tao12345666333 wants to merge 2 commits intomainfrom
Conversation
tao12345666333
force-pushed
the
jt/fix-3441
branch
from
da33cf0 to
4fb9354
Compare
1 task
programmer04
previously approved these changes
Mar 10, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
tao12345666333
force-pushed
the
jt/fix-3441
branch
from
dafbbd4 to
60f1a62
Compare
Per the Gateway API spec, BackendRef Kind defaults to "Service" and Group defaults to empty when not explicitly set. Previously, nil Kind or Group fields in BackendRef could cause nil pointer dereferences or incorrect resolved-refs status conditions. This commit: - Defaults Kind to "Service" and Group to "" in BuildResolvedRefsCondition - Updates IsBackendRefSupported to treat nil/empty Kind as "Service" - Defaults backendRefKind to "Service" in IsHTTPReferenceGranted - Adds test coverage for the nil-kind scenarios - Removes HTTPRouteSimpleSameNamespace from hybrid skipped conformance tests Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
…mpty-string Kind handling Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
force-pushed
the
jt/fix-3441
branch
from
60f1a62 to
5a302ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes
Fixes #3441
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes