fix(ingress-controller): Add protocols in translated rotues#3587
Open
randmonkey wants to merge 3 commits intomainfrom
Open
fix(ingress-controller): Add protocols in translated rotues#3587randmonkey wants to merge 3 commits intomainfrom
randmonkey wants to merge 3 commits intomainfrom
Conversation
randmonkey
force-pushed
the
fix/set_route_protocol_expressions
branch
from
c086940 to
a42fa21
Compare
randmonkey
force-pushed
the
fix/set_route_protocol_expressions
branch
from
a42fa21 to
e452647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Set
protocolstohttp,httpsin translated routes when expression router is enabled.Which issue this PR fixes
Fixes #
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes