This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat(exporter) add url location and GET param counters, with regex extract#116
Open
samsk wants to merge 3 commits intoKong:masterfrom
Open
feat(exporter) add url location and GET param counters, with regex extract#116samsk wants to merge 3 commits intoKong:masterfrom
samsk wants to merge 3 commits intoKong:masterfrom
Conversation
Member
|
Hi @samsk, thanks for this PR. We are in the process of moving some external plugins into the Kong main repository. We have just merged this one into Kong. Issues were also moved. We have created a card to review this PR; once we do, we will cherry-pick changes here into Kong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this is a second revamp of pull request #113, implementing poor man`s alternative for URL endpoint usage tracking.
New features:
per-url param metric
param_collect_list, attaching its value asparamlabelkong_http_url_param_totalorkong_http_url_param_consumer_totaldepending onper_consumerswitchparam_value_extractregexp, (to avoid possible problems with metric cardinality)per-url location metric
locationlabelkong_http_url_location_totalorkong_http_url_location_consumer_totaldepending onper_consumerswitchlocation_extractregexpThese new metrics make sense especially for people that don't want to setup/run/maintain additional log-collection/extraction system (like fluentd/splunk) or implement any other kind of instrumentation systems. With this, they can still have at least a basic insight about per-consumer usage of their services identified by URL param and/or URL location (part).
Ideally, this features should be used together with consumer authentication (as it is in our use case), to further reduce possible metrics overpopulation problems.
Thank you