fix delete event in rpc.lua

Kong · Sep 30, 2024 · a1be884 · a1be884
1 parent fb59d6f
commit a1be884
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/kong/clustering/services/sync/rpc.lua b/kong/clustering/services/sync/rpc.lua
@@ -234,6 +234,7 @@ function _M:sync_once(delay)
         for _, delta in ipairs(ns_delta.deltas) do
           local delta_type = delta.type
           local delta_row = delta.row
+          local crud_event_type
 
           if delta_row ~= ngx_null then
             -- upsert the entity
@@ -243,7 +244,7 @@ function _M:sync_once(delay)
               return nil, err
             end
 
-            local crud_event_type = "create"
+            crud_event_type = "create"
 
             if old_entity then
               local res, err = delete_entity_for_txn(t, delta_type, old_entity, nil)
@@ -259,11 +260,11 @@ function _M:sync_once(delay)
               return nil, err
             end
 
-            crud_events_n = crud_events_n + 1
-            crud_events[crud_events_n] = { delta_type, crud_event_type, delta_row, old_entity, }
-
           else
             -- delete the entity
+            crud_event_type = "delete"
+            delta_row = nil
+
             local old_entity, err = kong.db[delta_type]:select({ id = delta.id, }) -- TODO: composite key
             if err then
               return nil, err
@@ -276,10 +277,11 @@ function _M:sync_once(delay)
               end
             end
 
-            crud_events_n = crud_events_n + 1
-            crud_events[crud_events_n] = { delta_type, "delete", old_entity, }
           end
 
+          crud_events_n = crud_events_n + 1
+          crud_events[crud_events_n] = { delta_type, crud_event_type, delta_row, old_entity, }
+
           -- XXX TODO: could delta.version be nil or ngx.null
           if type(delta.version) == "number" and delta.version ~= version then
             version = delta.version