Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cors): add an option to skip return ACAO when no origin in request #14155

Merged
merged 8 commits into from
Feb 17, 2025
Merged

feat(cors): add an option to skip return ACAO when no origin in request #14155

merged 8 commits into from
Feb 17, 2025

Conversation

lhanjian
Copy link
Contributor

@lhanjian lhanjian commented Jan 14, 2025 •
edited
Loading

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix FTI-6314

@github-actions github-actions bot added plugins/cors schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jan 14, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 15, 2025
@lhanjian lhanjian changed the title FTI-6314 feat(cors): add an option to skip return ACAO when no origin in request Jan 15, 2025
@lhanjian lhanjian marked this pull request as ready for review January 15, 2025 07:53
@lhanjian lhanjian force-pushed the FTI-6314 branch 3 times, most recently from 9b74ecb to b353adf Compare January 22, 2025 03:31
@lhanjian
Copy link
Contributor Author

@raoxiaoyan already rebase pr#14206

@windmgc windmgc merged commit 87e9a76 into master Feb 17, 2025
28 checks passed
@windmgc windmgc deleted the FTI-6314 branch February 17, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms2008 ms2008 ms2008 approved these changes

@outsinre outsinre outsinre approved these changes

@raoxiaoyan raoxiaoyan raoxiaoyan approved these changes

Assignees

@lhanjian lhanjian

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering plugins/cors schema-change-noteworthy size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lhanjian @ms2008 @outsinre @raoxiaoyan @windmgc