Skip to content

fix(key-auth): change hide_credentials behaviour #14656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(key-auth): change hide_credentials behaviour #14656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/unreleased/kong/fix-key-auth-remove-creds-in-all-locations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
message: Key-auth plugin "hide_credentials" parameter now removes credentials only in search locations
type: bugfix
scope: Plugin

8 changes: 6 additions & 2 deletions kong/plugins/key-auth/handler.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,12 @@ local function do_authentication(conf)
key = v

if conf.hide_credentials then
kong.service.request.clear_query_arg(name)
kong.service.request.clear_header(name)
if conf.key_in_query then
kong.service.request.clear_query_arg(name)
end
if conf.key_in_header then
kong.service.request.clear_header(name)
end

if conf.key_in_body then
if not body then
Expand Down