-
Notifications
You must be signed in to change notification settings - Fork 5k
[DO NOT MERGE] chore(*): side by side PR diffs #14756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nowNick
wants to merge
1
commit into
master
Choose a base branch
from
chore/side-by-side-pr-diffs--base
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2025
Similarity: 50.0%Compared:
Similarity: 🟩🟩🟩🟩🟩🟥🟥🟥🟥🟥 (3/6 identical)
|
# | ||
---|---|---|
1 | Hunk is identical (md5: ed9b350f1ec7e7cb7a7855b764b69506 ) |
|
2 |
@@ -114,6 +115,7 @@ describe("kong.db [#postgres] connector", function()
end)
end)
+ -- Some random changes in a file --- 222
describe(":query() semaphore", function()
describe("max 1", function()
-- connector in a new scope |
(no changes) |
3 | (no changes) |
@@ -360,7 +361,7 @@ describe("kong.db [#postgres] connector", function()
assert.same({ "cluster_events", "clustering_rpc_requests", "a", "workspaces", "services" }, ts({ services, a, workspaces }))
end)
-
+-- Some random changes in a file --- 222
it("returns an error if cycles are found", function()
local a = schema_new({
name = "a", |
📄 spec/01-unit/22-grpc-utils_spec.lua
# | ||
---|---|---|
1 |
@@ -28,6 +28,7 @@ describe("grpc tools", function()
}, methods)
end)
+ -- Some random changes in a file --- 11
it("imports recursively", function()
local methods = {}
local grpc_tools_instance = grpc_tools.new() |
(no changes) |
📄 spec/03-plugins/23-rate-limiting/04-access_spec.lua
# | ||
---|---|---|
1 |
@@ -51,7 +51,7 @@ local function GET(url, opt)
return res
end
-
+-- Some random changes in a file --- 11
local function client_requests(n, proxy_fn)
local ret = { |
(no changes) |
2 |
@@ -90,7 +90,7 @@ local function client_requests(n, proxy_fn)
return ret
end
-
+-- Some random changes in a file --- 222
local function validate_headers(headers, check_minute, check_hour)
if check_minute then
assert.same({ |
(no changes) |
3 |
@@ -219,7 +219,7 @@ local function setup_rl_plugin(admin_client, conf, service, consumer)
return cjson.decode(assert.res_status(201, plugin))
end
-
+-- Some random changes in a file --- 333
local function setup_key_auth_plugin(admin_client, conf, service)
local plugin |
(no changes) |
4 | (no changes) |
@@ -52,7 +52,6 @@ local function GET(url, opt)
return res
end
-
local function client_requests(n, proxy_fn)
local ret = {
minute_limit = {}, |
5 | (no changes) |
@@ -90,7 +89,7 @@ local function client_requests(n, proxy_fn)
return ret
end
-
+-- Some random changes in a file --- 222
local function validate_headers(headers, check_minute, check_hour)
if check_minute then
assert.same({ |
6 | (no changes) |
@@ -219,7 +218,7 @@ local function setup_rl_plugin(admin_client, conf, service, consumer)
return cjson.decode(assert.res_status(201, plugin))
end
-
+-- Some random changes in a file --- 333
local function setup_key_auth_plugin(admin_client, conf, service)
local plugin |
Identical files
kong/init.lua
spec/01-unit/27-queue_spec.lua
spec/03-plugins/23-rate-limiting/03-api_spec.lua
Similarity: 50.0%Compared:
Similarity: 🟩🟩🟩🟩🟩🟥🟥🟥🟥🟥 (3/6 identical)
|
# | ||
---|---|---|
1 | (no changes) |
@@ -6,7 +6,7 @@ local config = {
local Schema = require "kong.db.schema"
local connector = require "kong.db.strategies.postgres.connector".new(config)
-
+-- Some random changes in a file --- 0000
describe("kong.db [#postgres] connector", function()
describe(":infos()", function()
it("returns infos db_ver always with two digit groups divided with dot (.)", function() |
2 | Hunk is identical (md5: ed9b350f1ec7e7cb7a7855b764b69506 ) |
|
3 | Hunk is identical (md5: c3c3e5ed7200288c182a43c867e0adce ) |
📄 spec/03-plugins/23-rate-limiting/03-api_spec.lua
# | ||
---|---|---|
1 | Hunk is identical (md5: 8889d02f717800b714ddaf3d58b8155c ) |
|
2 | (no changes) |
@@ -160,7 +160,7 @@ for _, strategy in helpers.each_strategy() do
local body = cjson.decode(assert.res_status(201, res))
assert.equal("local", body.config.policy)
end)
-
+ -- Some random changes in a file --- 222
it("does allow setting policy to cluster on non-dbless", function()
local res = admin_client:post("/plugins", {
body = { |
📄 spec/03-plugins/23-rate-limiting/04-access_spec.lua
# | ||
---|---|---|
1 | (no changes) |
@@ -15,7 +15,7 @@ local fmt = string.format
local proxy_client = helpers.proxy_client
local table_insert = table.insert
local tonumber = tonumber
-
+-- Some random changes in a file --- 000
local ngx_sleep = ngx.sleep
local ngx_now = ngx.now |
2 | Hunk is identical (md5: 87e482d75a625b9c831dddbe725f9154 ) |
|
3 | Hunk is identical (md5: 80bfa6de41a2ca58ca1faaa9273c2cf7 ) |
|
4 | (no changes) |
@@ -130,7 +130,7 @@ local function validate_headers(headers, check_minute, check_hour)
elseif check_minute then
assert.equal(true, reset <= 60 and reset >= 0)
-
+-- Some random changes in a file --- 222_333_111
else
error("check_hour or check_minute must be true")
end |
5 | (no changes) |
@@ -174,7 +174,7 @@ end
local function setup_rl_plugin(admin_client, conf, service, consumer)
local plugin
-
+-- Some random changes in a file --- 222_333_222
if service then
plugin = assert(admin_client:send({
method = "POST", |
6 | Hunk is identical (md5: 3bf492ba752c47ee8174debcb70ee079 ) |
Identical files
kong/init.lua
spec/01-unit/22-grpc-utils_spec.lua
spec/01-unit/27-queue_spec.lua
Similarity: 100.0%Compared:
Similarity: 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 (6/6 identical)
|
/prdiff #14757 |
📝 Diff from #14757Click to expand--- /dev/fd/63 2025-09-15 17:13:22
+++ /dev/fd/62 2025-09-15 17:13:22
@@ -1,2 +1,2 @@
---- a/kong/init.lua # [PR: 14756]
-+++ b/kong/init.lua # [PR: 14756]
+--- a/kong/init.lua # [PR: 14757]
++++ b/kong/init.lua # [PR: 14757]
@@ -7,2 +7,2 @@
---- a/spec/01-unit/01-db/06-postgres_spec.lua # [PR: 14756]
-+++ b/spec/01-unit/01-db/06-postgres_spec.lua # [PR: 14756]
+--- a/spec/01-unit/01-db/06-postgres_spec.lua # [PR: 14757]
++++ b/spec/01-unit/01-db/06-postgres_spec.lua # [PR: 14757]
@@ -10,6 +9,0 @@
-+ -- Some random changes in a file --- 222
---- a/spec/01-unit/22-grpc-utils_spec.lua # [PR: 14756]
-+++ b/spec/01-unit/22-grpc-utils_spec.lua # [PR: 14756]
-+ -- Some random changes in a file --- 11
---- a/spec/01-unit/27-queue_spec.lua # [PR: 14756]
-+++ b/spec/01-unit/27-queue_spec.lua # [PR: 14756]
@@ -16,0 +11,4 @@
++-- Some random changes in a file --- 222
+--- a/spec/01-unit/27-queue_spec.lua # [PR: 14757]
++++ b/spec/01-unit/27-queue_spec.lua # [PR: 14757]
+-
@@ -18,2 +16,2 @@
---- a/spec/03-plugins/23-rate-limiting/03-api_spec.lua # [PR: 14756]
-+++ b/spec/03-plugins/23-rate-limiting/03-api_spec.lua # [PR: 14756]
+--- a/spec/03-plugins/23-rate-limiting/03-api_spec.lua # [PR: 14757]
++++ b/spec/03-plugins/23-rate-limiting/03-api_spec.lua # [PR: 14757]
@@ -22,2 +20,2 @@
---- a/spec/03-plugins/23-rate-limiting/04-access_spec.lua # [PR: 14756]
-+++ b/spec/03-plugins/23-rate-limiting/04-access_spec.lua # [PR: 14756]
+--- a/spec/03-plugins/23-rate-limiting/04-access_spec.lua # [PR: 14757]
++++ b/spec/03-plugins/23-rate-limiting/04-access_spec.lua # [PR: 14757]
@@ -25 +22,0 @@
-+-- Some random changes in a file --- 11 |
Similarity: 75.0%Compared:
Hunk similarity: 🟩🟩🟩🟩🟨🟨🟨🟨🟥🟥 (5/4/2 exact/similar/different of total 12 hunks)
|
# | Match type | ||
---|---|---|---|
1 | Hunk is identical (md5: ed9b350f1ec7e7cb7a7855b764b69506 ) |
||
2 |
@@ -114,6 +115,7 @@ describe("kong.db [#postgres] connector", function()
end)
end)
+ -- Some random changes in a file --- 222
describe(":query() semaphore", function()
describe("max 1", function()
-- connector in a new scope |
@@ -360,7 +361,7 @@ describe("kong.db [#postgres] connector", function()
assert.same({ "cluster_events", "clustering_rpc_requests", "a", "workspaces", "services" }, ts({ services, a, workspaces }))
end)
-
+-- Some random changes in a file --- 222
it("returns an error if cycles are found", function()
local a = schema_new({
name = "a", |
Core diff match 🟨 |
📄 spec/03-plugins/23-rate-limiting/04-access_spec.lua
# | Match type | ||
---|---|---|---|
1 |
@@ -51,7 +51,7 @@ local function GET(url, opt)
return res
end
-
+-- Some random changes in a file --- 11
local function client_requests(n, proxy_fn)
local ret = { |
(no changes) | Not matching 🟥 |
2 | (no changes) |
@@ -52,7 +52,6 @@ local function GET(url, opt)
return res
end
-
local function client_requests(n, proxy_fn)
local ret = {
minute_limit = {}, |
Not matching 🟥 |
3 |
@@ -90,7 +90,7 @@ local function client_requests(n, proxy_fn)
return ret
end
-
+-- Some random changes in a file --- 222
local function validate_headers(headers, check_minute, check_hour)
if check_minute then
assert.same({ |
@@ -90,7 +89,7 @@ local function client_requests(n, proxy_fn)
return ret
end
-
+-- Some random changes in a file --- 222
local function validate_headers(headers, check_minute, check_hour)
if check_minute then
assert.same({ |
Core diff match 🟨 |
4 |
@@ -219,7 +219,7 @@ local function setup_rl_plugin(admin_client, conf, service, consumer)
return cjson.decode(assert.res_status(201, plugin))
end
-
+-- Some random changes in a file --- 333
local function setup_key_auth_plugin(admin_client, conf, service)
local plugin |
@@ -219,7 +218,7 @@ local function setup_rl_plugin(admin_client, conf, service, consumer)
return cjson.decode(assert.res_status(201, plugin))
end
-
+-- Some random changes in a file --- 333
local function setup_key_auth_plugin(admin_client, conf, service)
local plugin |
Core diff match 🟨 |
Identical files
kong/init.lua
spec/01-unit/27-queue_spec.lua
spec/03-plugins/23-rate-limiting/03-api_spec.lua
Similarity: 75.0%Compared:
Hunk similarity: 🟩🟩🟩🟩🟨🟨🟨🟨🟥🟥 (5/4/2 exact/similar/different of total 12 hunks)
|
# | ||
---|---|---|
1 🟩 |
Hunk is identical (md5: ed9b350f1ec7e7cb7a7855b764b69506 ) |
|
2 🟨 |
@@ -114,6 +115,7 @@ describe("kong.db [#postgres] connector", function()
end)
end)
+ -- Some random changes in a file --- 222
describe(":query() semaphore", function()
describe("max 1", function()
-- connector in a new scope |
@@ -360,7 +361,7 @@ describe("kong.db [#postgres] connector", function()
assert.same({ "cluster_events", "clustering_rpc_requests", "a", "workspaces", "services" }, ts({ services, a, workspaces }))
end)
-
+-- Some random changes in a file --- 222
it("returns an error if cycles are found", function()
local a = schema_new({
name = "a", |
📄 spec/03-plugins/23-rate-limiting/04-access_spec.lua
# | ||
---|---|---|
1 🟥 |
@@ -51,7 +51,7 @@ local function GET(url, opt)
return res
end
-
+-- Some random changes in a file --- 11
local function client_requests(n, proxy_fn)
local ret = { |
(no changes) |
2 🟥 |
(no changes) |
@@ -52,7 +52,6 @@ local function GET(url, opt)
return res
end
-
local function client_requests(n, proxy_fn)
local ret = {
minute_limit = {}, |
3 🟨 |
@@ -90,7 +90,7 @@ local function client_requests(n, proxy_fn)
return ret
end
-
+-- Some random changes in a file --- 222
local function validate_headers(headers, check_minute, check_hour)
if check_minute then
assert.same({ |
@@ -90,7 +89,7 @@ local function client_requests(n, proxy_fn)
return ret
end
-
+-- Some random changes in a file --- 222
local function validate_headers(headers, check_minute, check_hour)
if check_minute then
assert.same({ |
4 🟨 |
@@ -219,7 +219,7 @@ local function setup_rl_plugin(admin_client, conf, service, consumer)
return cjson.decode(assert.res_status(201, plugin))
end
-
+-- Some random changes in a file --- 333
local function setup_key_auth_plugin(admin_client, conf, service)
local plugin |
@@ -219,7 +218,7 @@ local function setup_rl_plugin(admin_client, conf, service, consumer)
return cjson.decode(assert.res_status(201, plugin))
end
-
+-- Some random changes in a file --- 333
local function setup_key_auth_plugin(admin_client, conf, service)
local plugin |
Identical files
kong/init.lua
spec/01-unit/27-queue_spec.lua
spec/03-plugins/23-rate-limiting/03-api_spec.lua
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR exists only to highlight how
pr diff
utility might work.Related PRs:
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]