-
Notifications
You must be signed in to change notification settings - Fork 12
feat: added imperative get support for system-accounts #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds imperative get support for system accounts in the Konnect CLI, allowing users to retrieve and list system account information through direct commands.
Changes:
- Added
SystemAccountsAPIinterface and implementation in the helpers package for SDK abstraction - Implemented
get system_accountcommand with support for listing all system accounts and fetching by ID or name - Integrated the new command into the root-level
getverb for direct access
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/konnect/helpers/system_accounts.go | Defines the SystemAccountsAPI interface and implementation for listing and getting system accounts |
| internal/konnect/helpers/sdk_mock.go | Adds mock factory support for SystemAccountsAPI testing |
| internal/konnect/helpers/sdk.go | Registers the SystemAccountsAPI getter in the main SDK interface |
| internal/cmd/root/verbs/get/system_account.go | Creates the direct system account command with Konnect-specific flag bindings |
| internal/cmd/root/verbs/get/get.go | Integrates the system account command into the root get verb |
| internal/cmd/root/products/konnect/system_account/system_account.go | Defines the system account command structure with metadata and aliases |
| internal/cmd/root/products/konnect/system_account/getSystemAccount.go | Implements the core logic for listing and getting system accounts with pagination support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
internal/cmd/root/products/konnect/system_account/system_account.go
Outdated
Show resolved
Hide resolved
internal/cmd/root/products/konnect/system_account/system_account.go
Outdated
Show resolved
Hide resolved
internal/cmd/root/products/konnect/system_account/system_account.go
Outdated
Show resolved
Hide resolved
internal/cmd/root/products/konnect/system_account/getSystemAccount.go
Outdated
Show resolved
Hide resolved
internal/cmd/root/products/konnect/system_account/getSystemAccount.go
Outdated
Show resolved
Hide resolved
internal/cmd/root/products/konnect/system_account/getSystemAccount.go
Outdated
Show resolved
Hide resolved
2954f5f to
a74af31
Compare
Summary
In this PR, we are adding
getandlistsupport forsystem-account resources.
As the underlying API doesn't support labels yet,
we are just supporting read operations over these
resources.
Operations supported:
Issues resolved
For #258
Documentation
Testing