Conversation
…nario Agent-Logs-Url: https://github.com/Kong/kongctl/sessions/a6a383a1-ee21-44a3-8084-8aa341898271 Co-authored-by: rspurgeon <10521262+rspurgeon@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR strengthens the E2E “control-plane sync” scenario by asserting additional fields after the sync-with-delete step, reducing the chance of regressions slipping through when the control plane still exists but key fields are wrong.
Changes:
- Extend the existing post-sync list assertion for
kongctl-e2e-cp-2to also validatedescription. - Add a new post-sync “get by name” verification command to assert
descriptionandconfig.cluster_typefrom the single-resource JSON output.
|
@copilot this scenario change adds a second kongctl get command to check the values of the same object. Instead, how about extending the assertions in the existing 001-002-verify-post-sync step instead of authoring an entirely new step with a redundant 'kongctl get' to retrieve essentially the same data as the prior step. |
Agent-Logs-Url: https://github.com/Kong/kongctl/sessions/99b960f9-e09a-4c4a-978b-248d688e9ee0 Co-authored-by: rspurgeon <10521262+rspurgeon@users.noreply.github.com>
Done in 534d533. Removed the separate |
The
002-sync-with-deletesync step only verified existence ofkongctl-e2e-cp-2by name after sync, leavingdescriptionandcluster_typeunasserted — a regression in either field would pass undetected.Changes
001-002-verify-post-sync— extended the existing list-based assertions forkongctl-e2e-cp-2to also assertdescriptionandconfig.cluster_type, using JMESPath selects on the same list response:No overlay or testdata changes — pure assertion additions in the existing verification step, consistent with the
applyscenario's002-001-verify-fieldspattern.