Skip to content

chore(types): type check all files including tests #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
johncowen wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(types): type check all files including tests #2752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"docs:dev": "vitepress dev docs",
"docs:serve": "vitepress serve docs",
"docs:preview": "vitepress preview docs --port 8080",
"typecheck": "vue-tsc -p './tsconfig.build.json' --noEmit",
"typecheck": "vue-tsc --noEmit",
Copy link
Member

@adamdehaven adamdehaven May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't exclude the tsconfig.build.json here, but rather update it to include all types we want to check.

There are some types in the project that likely should be excluded from checking during the build/release process.

Copy link
Contributor Author

@johncowen johncowen May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I'm fine whichever. I guess whichever option means we get typechecking on .ts files.

Do you have an example of which files likely should be excluded? (that are a different set to those that are in tsconfig.json)

Copy link
Contributor Author

@johncowen johncowen May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just incase/FYI I wasn't planning on finishing up this one myself/personally it was just to give a reproduction of the issue. I'd rather leave it to the owners of the repo to decide how to proceed seeing as it will need a good bit of fix up in the tests. In my mind as long as .ts files are being run through typescript/being typechecked then its fine by me 👍

"lint": "eslint",
"lint:fix": "eslint --fix",
"stylelint": "stylelint './src/**/*.{css,scss,sass,vue}'",
Expand Down
Loading