fix: add sameDayFullRange prop to allow valid time range for same day queries [MA-4646]#3070
Open
jordojordo wants to merge 2 commits intomainfrom
Open
fix: add sameDayFullRange prop to allow valid time range for same day queries [MA-4646]#3070jordojordo wants to merge 2 commits intomainfrom
jordojordo wants to merge 2 commits intomainfrom
Conversation
jordojordo
requested review from
a team,
Justineo,
adamdehaven and
jillztom
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jordojordo
force-pushed
the
fix/ma-4646
branch
from
700f0b8 to
d3dee60
Compare
jordojordo
force-pushed
the
fix/ma-4646
branch
from
d3dee60 to
b4b14e9
Compare
Collaborator
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MA-4646
Summary
This will add a new prop (
sameDayFullRange) to theKDateTimePickerandCalendarWrappercomponents to allow for valid time ranges when a user selects the same day for a start and end time.When enabled and the same date is chosen for the start and end, the time range will automatically be adjusted to
12:00am to11:59pm of the same day, as opposed to the12:00am and12:00am for both start and end times.Another callback prop has been added
customValidationRangewhich will allow for custom validation ofstartandendtimes to disable the "Apply" button in KDateTimePicker.This also refactors a little bit of repeated and messy type guarding within the CalendarWrapper.