Feat(Konnect): add fields for adopting existing konnect entities #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
force-pushed
the
feat/spec_konnect_entityid
branch
2 times, most recently
from
128c0a6 to
33df9ea
Compare
randmonkey
force-pushed
the
feat/spec_konnect_entityid
branch
from
33df9ea to
415d370
Compare
|
Moving to 1.6 as this feature was punted from 1.5. |
|
Kong/kong-operator#460 has been moved to 2.0 so assigning this to 2.0 as well. |
|
Readjusting milestone as it's not going to land in KO 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
spec.konnect.adopt.idfor adopting an existing entity. This PR adds the spec and validation rules forKongServiceandKonnectGatewayControlPlane.Which issue this PR fixes
Part of Kong/kong-operator#2277
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes