Fix: set protocols in translated expression based routes#7860
Open
randmonkey wants to merge 2 commits intomainfrom
Open
Fix: set protocols in translated expression based routes#7860randmonkey wants to merge 2 commits intomainfrom
randmonkey wants to merge 2 commits intomainfrom
Conversation
randmonkey
force-pushed
the
fix/set_route_protocols_expressions
branch
from
9e337b6 to
253c985
Compare
randmonkey
force-pushed
the
fix/set_route_protocols_expressions
branch
from
253c985 to
dfdc6e7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7860 +/- ##
=======================================
- Coverage 80.4% 78.5% -2.0%
=======================================
Files 222 222
Lines 20958 20792 -166
=======================================
- Hits 16869 16327 -542
- Misses 3104 3438 +334
- Partials 985 1027 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pmalek
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Set
protocolsin translated routes to[http, https]in expression routes.Which issue this PR fixes:
fixes #7859
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR