fix: loosen metric dimension and filter dimension types in dashboard schema#3049
fix: loosen metric dimension and filter dimension types in dashboard schema#3049filipgutica wants to merge 3 commits intomainfrom
Conversation
filipgutica
force-pushed
the
fix/loosen-metric-dimension-types-dashboard-schema
branch
from
e3d13c4 to
4521ced
Compare
filipgutica
force-pushed
the
fix/loosen-metric-dimension-types-dashboard-schema
branch
2 times, most recently
from
d59ee57 to
63a93fe
Compare
| expect(result).toEqual(expected) | ||
| }) | ||
|
|
||
| it('keeps all filters for platform', () => { |
There was a problem hiding this comment.
Is this the behaviour we want for platform?
There was a problem hiding this comment.
It certainly isn't the right long-term behavior. However, given the timeline, maybe we let it pass and try to follow up with the refactor that looks at the datasource config store.
filipgutica
force-pushed
the
fix/loosen-metric-dimension-types-dashboard-schema
branch
from
63a93fe to
1379b37
Compare
| expect(result).toEqual(expected) | ||
| }) | ||
|
|
||
| it('keeps all filters for platform', () => { |
There was a problem hiding this comment.
It certainly isn't the right long-term behavior. However, given the timeline, maybe we let it pass and try to follow up with the refactor that looks at the datasource config store.
| } = query | ||
|
|
||
| const datasource = originalDatasource || 'basic' | ||
| const datasource = originalDatasource |
There was a problem hiding this comment.
Could you add a comment explaining what this is doing?
| zoomable: false, | ||
| } | ||
|
|
||
| it('falls back to api_usage for unknown datasources', async () => { |
There was a problem hiding this comment.
Why do you want to do this? (I don't think it's a problem, just curious what case cropped up that causes the need for it.)
There was a problem hiding this comment.
Isn't this what the behaviour always was?
| filters: [{ field: 'status_code', operator: 'in', value: ['test1'] }], | ||
| } | ||
| mount({ context }) | ||
| mount({ context, waitForDatasourceConfigStore: true }) |
There was a problem hiding this comment.
Does this option do anything?
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR: |
3 participants
Summary
https://konghq.atlassian.net/browse/MA-4897