Skip to content

Enhancement of Mrujs in relation to Turbo #146

Description

@KonnorRogers

@seanpdoyle described a number of exciting, and intriguing points here in this PR:

hotwired/turbo-rails#257 (comment)

For example, his data-confirm implementation excites me since I currently have a very hacky data-async-confirm solution. In addition, there are many other items such as respecting frames on form submissions that is important for working in a Turbo enabled app.

There are some things that may not apply. For example, data-method in mrujs constructs a Fetch request under the hood and does not actually submit a full form, as well as some turbo-specific things such as request-start since mrujs will handle its own lifecycle of ajax: events this may not be necessary.

Regardless, over the next few days I plan to go in and pluck key points out from his post / PR and hope to start implementing some of these features into Mrujs since theyre exciting to me and I think they should be considered.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions