Skip to content

docs: journey-traceability + iconography implementation - #558

Merged
KooshaPari merged 1 commit into
mainfrom
feat/journey-impl
May 1, 2026
Merged

docs: journey-traceability + iconography implementation#558
KooshaPari merged 1 commit into
mainfrom
feat/journey-impl

Conversation

@KooshaPari

@KooshaPari KooshaPari commented May 1, 2026

Copy link
Copy Markdown
Owner

User description

Journey traceability + Fluent/Material iconography SVGs + CI gate for helios-cli. Stub manifests — populate to pass CI.

Co-authored-by: Claude Opus 4.7 noreply@anthropic.com


Note

Medium Risk
Adds a new GitHub Actions gate that can fail PRs/pushes when no manifest.verified.json exists or when validation/assertions fail, and it installs/downloads external tooling during CI. Other changes are documentation/assets only.

Overview
Introduces a new Journey Gate GitHub Actions workflow that installs tesseract and phenotype-journey, discovers manifest.verified.json files, validates them, runs assertions in strict mode by default, and optionally performs live verification using ANTHROPIC_API_KEY.

Adds initial journey traceability documentation and a stub journey manifest under docs/journeys/manifests/, plus a documented iconography spec and a set of Fluent/Material SVG icon assets under docs/operations/iconography/.

Reviewed by Cursor Bugbot for commit 2ec31bb. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Add journey traceability docs, icon guidance, and a CI gate for manifests

What Changed

  • Added journey traceability guidance for the CLI, including the main user flows it should cover and where journey manifests live
  • Added an iconography spec and SVG assets guidance for the supported icon styles
  • Added a CI gate that checks for journey manifests, validates them, and fails PRs when manifests are missing or checks do not pass
  • Added a starter journey manifest so the new gate has a concrete repository path to check

Impact

✅ Clearer release checks for CLI journeys
✅ Fewer missing-manifest surprises in pull requests
✅ Consistent icon usage across docs and assets

🔄 Retrigger CodeAnt AI Review

Details

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 1, 2026 15:43
@KooshaPari
KooshaPari merged commit d06a541 into main May 1, 2026
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@codeant-ai

codeant-ai Bot commented May 1, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:L This PR changes 100-499 lines, ignoring generated files label May 1, 2026
@codeant-ai

codeant-ai Bot commented May 1, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 6 potential issues.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2ec31bb. Configure here.

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="24" height="24" role="img" aria-label="search" focusable="false" fill="none" stroke="currentColor" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round"><path d="M21 21l-4.35-4.35M11 19a8 8 0 1 0-16 8 8 8 0 0 0 16z"/></svg> No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search icon SVG path draws outside viewBox

High Severity

The magnifying glass circle path a8 8 0 1 0-16 8 8 8 0 0 0 16z is malformed. The first arc's dx/dy of (-16, 8) draws to point (-5, 27), far outside the 0 0 24 24 viewBox, and the second arc has only 6 parameters instead of 7. A correct search circle starting at (11, 19) would use a8 8 0 1 0 0-16 8 8 0 0 0 0 16z — it appears a 0 was dropped causing the dx and dy values to shift. Both fluent and material versions share this broken path.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2ec31bb. Configure here.

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="24" height="24" role="img" aria-label="workflow" focusable="false" fill="none" stroke="currentColor" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round"><path d="M16 18l6-6-6-6M8 6l-6 6 6 12"/></svg> No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow icon left chevron has wrong proportions

Medium Severity

The left-facing chevron path M8 6l-6 6 6 12 draws its bottom arm to (8, 24) — extending to the very edge of the viewBox and making it twice as long as the top arm. The right chevron uses symmetric l6-6-6-6, so the left chevron's final segment likely needs 6 6 instead of 6 12 to match. Both fluent and material versions share this asymmetric path.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2ec31bb. Configure here.

- name: Run assertions
env:
MANIFEST_LIST: ${{ steps.discover.outputs.MANIFEST_LIST }}
PHENOTYPE_JOURNEY_STRICT: ${{ inputs.strict_mode && 'true' || 'false' }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strict mode silently disabled on push/PR triggers

High Severity

The step-level env PHENOTYPE_JOURNEY_STRICT: ${{ inputs.strict_mode && 'true' || 'false' }} evaluates to 'false' for push and pull_request triggers because inputs.strict_mode is undefined (inputs only exist for workflow_dispatch). This overrides the top-level env on line 48 which correctly defaults to 'true'. Assertion violations will silently pass on all CI push/PR runs, defeating the stated purpose of the gate.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2ec31bb. Configure here.

name: Journey Gate — No Manifests Found
runs-on: ubuntu-latest
needs: journey-gate
if: needs.journey-gate.result == 'failure' && needs.journey-gate.outputs.MANIFEST_COUNT == '0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stub-mode job can never run due to missing outputs

Medium Severity

The stub-mode job checks needs.journey-gate.outputs.MANIFEST_COUNT == '0', but the journey-gate job never declares a job-level outputs: block to expose the step output. GitHub Actions requires an explicit outputs: mapping on the job to propagate step outputs across jobs. Without it, MANIFEST_COUNT is always empty, the condition is never satisfied, and the stub-mode guidance never appears.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2ec31bb. Configure here.

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="24" height="24" role="img" aria-label="branch" focusable="false" fill="currentColor"><path d="M6 3v12M18 6a3 3 0 0 1 0 6M6 18a3 3 0 0 1 0-6M18 9a9 9 0 0 1 0 9"/></svg> No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Material icons reuse stroke paths producing invisible elements

Medium Severity

The material icons duplicate the fluent (stroke) icon paths verbatim but swap stroke="currentColor" for fill="currentColor" without adapting the path data. Open/linear subpaths produce zero-area shapes with fill and become invisible. In material/branch.svg, the trunk line M6 3v12 is entirely invisible. In material/terminal.svg, the cursor line M12 19h8 disappears. Filled "Material" icons need closed-area paths to render correctly.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2ec31bb. Configure here.

id: discover
run: |
GLOB="${MANIFEST_PATH:-**/manifest.verified.json}"
echo "Glob pattern: $GLOB"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow dispatch manifest_path input is silently ignored

Low Severity

The manifest_path workflow_dispatch input is never wired to an environment variable. Line 105 reads $MANIFEST_PATH (never defined), so GLOB always gets the default value. Then GLOB itself is only printed — the find command on the next lines is hardcoded with -name "manifest.verified.json". The user-facing input is accepted but has no effect on behavior.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2ec31bb. Configure here.

@KooshaPari
KooshaPari removed the request for review from Copilot May 1, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants