Skip to content

fix(workspace): declare 19 missing workspace dependencies - #571

Merged
KooshaPari merged 1 commit into
mainfrom
fix/workspace-deps-declared
Jun 2, 2026
Merged

fix(workspace): declare 19 missing workspace dependencies#571
KooshaPari merged 1 commit into
mainfrom
fix/workspace-deps-declared

Conversation

@KooshaPari

@KooshaPari KooshaPari commented May 31, 2026

Copy link
Copy Markdown
Owner

User description

Stabilize wave: add workspace.dependencies entries required by codex-rs and workspace members.

Made with Cursor


Note

Low Risk
Build and workspace manifest changes only; no runtime behavior or security-sensitive logic is modified.

Overview
Workspace Cargo configuration is updated so codex-rs members can resolve shared crates through [workspace.dependencies] instead of failing during cargo metadata / builds.

The change adds a batch of previously missing workspace dependency aliases (internal codex-* crates and related paths) so member Cargo.toml files that reference { workspace = true } have a single declared source. It also drops a non-existent utils/git workspace member in favor of the existing git-utils / codex-git-utils wiring, and cleans up the CLI dependency list so codex-sandboxing is declared once after a merge conflict.

No application logic changes—only how dependencies are declared at the workspace root.

Reviewed by Cursor Bugbot for commit 2f87a34. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Fix workspace dependency declarations so the repo can load and build cleanly

What Changed

  • Added missing workspace dependency entries so member crates can resolve shared internal and external packages without errors.
  • Removed a non-existent workspace member entry for utils/git.
  • Cleared a merge conflict in the CLI dependency list so the sandboxing dependency is declared once.

Impact

✅ Fewer workspace build failures
✅ Successful cargo metadata and dependency loading
✅ Cleaner CLI and workspace configuration

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Copilot AI review requested due to automatic review settings May 31, 2026 21:33
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@codeant-ai

codeant-ai Bot commented May 31, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label May 31, 2026
@codeant-ai

codeant-ai Bot commented May 31, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@KooshaPari KooshaPari closed this Jun 2, 2026
@KooshaPari
KooshaPari force-pushed the fix/workspace-deps-declared branch from 551bb98 to 249a6b3 Compare June 2, 2026 01:20
@codeant-ai

codeant-ai Bot commented Jun 2, 2026

Copy link
Copy Markdown

CodeAnt AI is running Incremental review


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai

codeant-ai Bot commented Jun 2, 2026

Copy link
Copy Markdown

CodeAnt AI Incremental review completed.

Co-authored-by: Cursor <cursoragent@cursor.com>
@KooshaPari KooshaPari reopened this Jun 2, 2026
@KooshaPari
KooshaPari merged commit 2871d0c into main Jun 2, 2026
6 of 8 checks passed
@KooshaPari
KooshaPari deleted the fix/workspace-deps-declared branch June 2, 2026 01:28
@kilo-code-bot

kilo-code-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: No action needed (PR is already merged and contains no changes)

Files Reviewed (0 files)
Other Observations

PR #571 is a duplicate PR that was closed; the actual changes were made in PR #527.


Reviewed by nemotron-3-super-120b-a12b-20230311:free · 523,392 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants