fix(codex-rs): add model-provider crates to workspace manifest - #611
Conversation
Partial repair for vendored codex-rs build; additional workspace deps still missing (rcgen, etc.).
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
🤖 CodeAnt AI — Review Status
Updated in place by CodeAnt AI · last 5 reviews |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c83322f92
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "lmstudio", | ||
| "login", | ||
| "mcp-server", | ||
| "model-provider", |
There was a problem hiding this comment.
Declare the provider's inherited workspace deps
Adding model-provider as a workspace member makes Cargo load codex-rs/model-provider/Cargo.toml, but that manifest inherits codex-agent-identity, codex-aws-auth, codex-models-manager, and codex-response-debug-context from [workspace.dependencies], and none of those keys are defined in this root manifest. Any workspace/package build that reaches the newly advertised provider crate still aborts during manifest parsing, so the provider's inherited dependencies need to be added as part of this repair.
Useful? React with 👍 / 👎.
Add missing internal crate paths and external workspace dependencies so codex-rs members resolve past model-provider and protocol crates. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Drop absent debug-client/cloud-requirements/test-macros from workspace; restore json-to-toml lib.rs. Cargo.lock still needs sqlite links unification for full codex-cli build. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Bump sqlx to 0.9 with sqlite-bundled to unify libsqlite3-sys 0.37; align v8 pin with upstream for code-mode sandbox feature. Co-authored-by: Cursor <cursoragent@cursor.com>
Bump starlark to 0.14.2, enable reqwest cookies, add missing TransportError/StreamError and wire retry/sse/telemetry to fork-local types; restore execpolicy decision module. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Match Http error url type to request String; switch rustls crypto provider to aws_lc_rs for rustls-provider crate. Co-authored-by: Cursor <cursoragent@cursor.com>
Pull lib.rs and model modules from upstream openai/codex to unblock codex-cli manifest resolution past backend-client. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|



User description
Summary
Partial repair for vendored codex-rs workspace — adds model-provider + model-provider-info to members and workspace.dependencies.
Note
Build still blocked on additional missing workspace deps (rcgen, etc.). Unblocks next tranche of codex-rs manifest repair.
Made with Cursor
CodeAnt-AI Description
Add missing model-provider crates to the codex-rs workspace
What Changed
model-providerandmodel-provider-infocrates to the workspace so they are included in buildsImpact
✅ Fewer workspace build failures✅ Unblocks codex-rs builds that depend on model provider crates✅ Faster progress on vendored build repair💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.