Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/trunk-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Trunk Check
uses: trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5 # v1.0.4
uses: trunk-io/trunk-action@04ba50e7658c81db7356da96657e6e77f220bfa3 # v1.3.1

- name: Trunk Upgrade (on schedule only)
if: github.event_name == 'schedule'
uses: trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5 # v1.0.4
uses: trunk-io/trunk-action@04ba50e7658c81db7356da96657e6e77f220bfa3 # v1.3.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use Trunk's upgrade subaction for scheduled upgrades

On scheduled runs this updated uses still resolves the root Trunk Check action, not the upgrade action; upstream v1.3.1 documents automatic upgrades with trunk-io/trunk-action/upgrade@v1, and its upgrade/action.yaml input is arguments for “trunk upgrade”, while the root action only defines arguments for checks. In this workflow the following trunk-args: --upgrade input is ignored, so the Monday job runs another check instead of creating an upgrade PR; point this line at /upgrade@04ba50e... and pass arguments if needed.

Useful? React with 👍 / 👎.

with:
trunk-args: --upgrade
Loading