fix(bazel): repair v8-canary config (llvm flag target + lockfile drift)

.bazelrc

@@ -18,7 +18,15 @@ common --enable_platform_specific_config
 common:linux --host_platform=//:local_linux
 common:windows --host_platform=//:local_windows
 common --@rules_cc//cc/toolchains/args/archiver_flags:use_libtool_on_macos=False
-common --@llvm//config:experimental_stub_libgcc_s
+# The hermetic LLVM toolchain module is imported as toolchains_llvm_bootstrapped
+# (see MODULE.bazel); the upstream @llvm name no longer exists in the repo map.
+common --@toolchains_llvm_bootstrapped//config:experimental_stub_libgcc_s
+
+# Bazelisk picks the latest Bazel (no .bazelversion), and the resolved module
+# graph (rules_cc 0.2.16 vs 0.2.17) differs between runs; both rewrite the
+# committed MODULE.bazel.lock and trip check-clean-worktree. Ignore the lockfile
+# for builds; the repository cache keeps module resolution cheap.
+build --lockfile_mode=off
 
 # TODO(zbarsky): rules_rust doesn't implement this flag properly with remote exec...
 # common --@rules_rust//rust/settings:pipelined_compilation

.github/scripts/rusty_v8_bazel.py

@@ -65,7 +65,7 @@ def bazel_output_files(
             "cquery",
             "-c",
             compilation_mode,
-            f"--platforms=@llvm//platforms:{platform}",
+            f"--platforms=@toolchains_llvm_bootstrapped//platforms:{platform}",
             *[f"--config={config}" for config in bazel_configs],
             "--output=files",
             expression,
@@ -90,7 +90,7 @@ def bazel_build(
             "build",
             "-c",
             compilation_mode,
-            f"--platforms=@llvm//platforms:{platform}",
+            f"--platforms=@toolchains_llvm_bootstrapped//platforms:{platform}",
             *[f"--config={config}" for config in bazel_configs],
             *download_args,
             *labels,

.github/workflows/rusty-v8-release.yml

@@ -66,7 +66,6 @@ jobs:
       actions: read
     environment:
       name: bazel
-      deployment: false
     strategy:
       fail-fast: false
       matrix:
@@ -198,11 +197,11 @@ jobs:
             build
             -c
             opt
-            "--platforms=@llvm//platforms:${PLATFORM}"
+            "--platforms=@toolchains_llvm_bootstrapped//platforms:${PLATFORM}"
             --config=rusty-v8-upstream-libcxx
             "--config=v8-target-${V8_CPU}"
             "${pair_target}"
-            --build_metadata=COMMIT_SHA=$(git rev-parse HEAD)
+            "--build_metadata=COMMIT_SHA=$(git rev-parse HEAD)"
           )
           if [[ "${SANDBOX}" != "true" ]]; then
             bazel_args+=(--config=v8-release-compat)

.github/workflows/v8-canary.yml

@@ -110,7 +110,6 @@ jobs:
       actions: read
     environment:
       name: bazel
-      deployment: false
     strategy:
       fail-fast: false
       matrix:
@@ -240,11 +239,12 @@ jobs:
 
           bazel_args=(
             build
-            "--platforms=@llvm//platforms:${PLATFORM}"
+            "--platforms=@toolchains_llvm_bootstrapped//platforms:${PLATFORM}"
             --config=rusty-v8-upstream-libcxx
             "--config=v8-target-${V8_CPU}"
             "${pair_target}"
-            --build_metadata=COMMIT_SHA=$(git rev-parse HEAD)
+            --verbose_failures
+            "--build_metadata=COMMIT_SHA=$(git rev-parse HEAD)"
           )
           if [[ "${SANDBOX}" != "true" ]]; then
             bazel_args+=(--config=v8-release-compat)

.gitignore

@@ -8,6 +8,11 @@ bazel-*
 build/
 out/
 
+# CI: upstream rusty_v8 checkout used by the v8-canary windows-source job.
+# The workflow checks this repo out into the workspace, so exclude it from
+# the check-clean-worktree gate (the checkout is intentional, not debris).
+/upstream-rusty-v8/
+
 # Node.js
 node_modules/
 .pnpm-store/

.taplo.toml

@@ -0,0 +1,6 @@
+# TOML formatting style for this repository (used by the `taplo` linter in
+# .trunk/trunk.yaml). The existing Cargo.toml files indent array entries
+# with 4 spaces, so keep taplo aligned with that instead of its 2-space
+# default.
+[formatting]
+indent_string = "    "

.trunk/.gitignore

@@ -0,0 +1,8 @@
+*out
+*logs
+*actions
+*notifications
+*tools
+plugins
+user_trunk.yaml
+user.yaml

.trunk/trunk.yaml

@@ -1,113 +1,83 @@
+---
 # =============================================================================
 # Trunk.io — Plugin versions for linting/formatting tools
 # =============================================================================
 # This file is auto-generated. Run `trunk upgrade` to update.
 # https://docs.trunk.io/check/reference
 # =============================================================================
 
-plugins:
-  sources:
-    - id: trunk
-      ref: v1.2.2
-    - id: community
-      ref: main
+version: 0.1
 
-# Linters (auto-detected by file type)
-linters:
-  actionlint:
-    enabled: true
-    commands:
-      - name: actionlint
-        run: actionlint ${target}
-        direct_configs:
-          - .github/workflows/*.yml
-  black:
-    enabled: true
-    commands:
-      - name: black
-        run: black --check --line-length 100 ${target}
-        direct_configs:
-          - pyproject.toml
-          - ruff.toml
-  clippy:
-    enabled: true
-    commands:
-      - name: clippy
-        run: cargo clippy --all-targets --all-features -- -D warnings
-  eslint:
-    enabled: true
-    direct_configs:
-      - .eslintrc.*
-      - eslint.config.*
-  golangci-lint:
-    enabled: true
-    direct_configs:
-      - .golangci.yml
-      - .golangci.yaml
-  mypy:
-    enabled: true
-    commands:
-      - name: mypy
-        run: mypy --ignore-missing-imports ${target}
-  ruff:
-    enabled: true
-    commands:
-      - name: ruff
-        run: ruff check --output-format=github ${target}
-        direct_configs:
-          - ruff.toml
-          - pyproject.toml
-  shellcheck:
-    enabled: true
-  taplo:
-    enabled: true
-  yamllint:
-    enabled: true
+# CLI version pinned for reproducible runs (matches the version CI downloads).
+cli:
+    version: 1.22.2
 
-# Formatters
-formatters:
-  black:
-    enabled: true
-    commands:
-      - name: black
-        run: black --line-length 100 ${target}
-        direct_configs:
-          - pyproject.toml
-  prettier:
-    enabled: true
-    direct_configs:
-      - .prettierrc
-      - prettier.config.*
-  rustfmt:
-    enabled: true
-    commands:
-      - name: rustfmt
-        run: rustfmt ${target}
+# The `trunk` plugin provides the linter/formatter definitions used below.
+# User definitions merge over the plugin: fields set in this file override the
+# plugin, everything else (files, tools, runtimes, version pins) is inherited.
+plugins:
+    sources:
+        - id: trunk
+          ref: v1.11.0
+          uri: https://github.com/trunk-io/plugins
 
-# Actions (CI optimization)
-actions:
-  trunk-check:
-    enabled: true
-    size: 5GB
-    memory: 16GB
-    disk: 10GB
-  trunk-merge:
-    enabled: true
-    size: 5GB
-  trunk-push:
-    enabled: true
-    size: 5GB
+lint:
+    # Repo-specific command overrides merged over the plugin definitions.
+    definitions:
+        # black: enforce 100-char line length in both lint and format modes.
+        - name: black
+          commands:
+              - name: lint
+                output: pass_fail
+                run: black --check --line-length 100 ${target}
+                success_codes: [0, 1]
+              - name: format
+                output: rewrite
+                run: black --line-length 100 ${target}
+                success_codes: [0]
+                batch: true
+                in_place: true
+                formatter: true
+        # clippy: lint all targets/features and fail on any warning.
+        - name: clippy
+          commands:
+              - name: lint
+                output: clippy
+                target: ${parent_with(Cargo.toml)}
+                run: >
+                    cargo clippy --message-format json --all-targets
+                    --all-features
+                    --locked -- -D warnings
+                success_codes: [0, 101, 383]
+                disable_upstream: true
 
-# Caching
-cache:
-  enabled: true
-  storage: local
+    # Enabled tools (plugin defaults unless overridden above). Versions are
+    # pinned explicitly: an unpinned entry resolves to the SYSTEM copy of the
+    # tool instead of a trunk-managed install.
+    enabled:
+        - actionlint@1.7.8
+        - black@25.9.0
+        - clippy@1.88.0
+        - eslint@8.10.0
+        - golangci-lint@2.6.1
+        - mypy@2.1.0
+        - prettier@3.6.2
+        - ruff@0.16.2
+        - rustfmt@1.88.0
+        - shellcheck@0.10.0
+        - taplo@0.10.0
+        - yamllint@1.37.1
 
-# CLI
-cli:
-  version: 1.22.2
+    # GitHub workflow files are covered by actionlint (syntax + shellcheck).
+    # prettier's YAML printer re-indents `on:`-keyed workflow files with a
+    # nonstandard style, and yamllint's 80-column default flags long action
+    # refs; neither reflects this repo's intent, so scope both off workflows.
+    ignore:
+        - linters: [prettier, yamllint]
+          paths:
+              - .github/workflows/**
 
-# Environment
-env:
-  variables:
-    EDITOR: vim
+# Git hooks: run `trunk check` before `git push`.
+actions:
+    enabled:
+        - trunk-check-pre-push

BUILD.bazel

@@ -9,7 +9,7 @@ platform(
     name = "local_linux",
     constraint_values = [
         # We mark the local platform as glibc-compatible because musl-built rust cannot dlopen proc macros.
-        "@llvm//constraints/libc:gnu.2.28",
+        "@toolchains_llvm_bootstrapped//constraints/libc:gnu.2.28",
     ],
     parents = ["@platforms//host"],
 )