Skip to content

chore(deps): inline ffi_utils to parking_lot (phenotype-shared deleted) - #627

Merged
KooshaPari merged 1 commit into
mainfrom
fix/inline-ffi_utils-to-parking_lot
Aug 10, 2026
Merged

chore(deps): inline ffi_utils to parking_lot (phenotype-shared deleted)#627
KooshaPari merged 1 commit into
mainfrom
fix/inline-ffi_utils-to-parking_lot

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 10, 2026

Copy link
Copy Markdown
Owner

User description

Summary

Inline the trivial ffi_utils crate (3 lines: re-export of parking_lot::Mutex as FfiMutex) into helios-cli directly. phenotype-shared is deleted.

Change

  • crates/harness_pyo3/Cargo.toml: drop ffi_utils path dep
  • crates/harness_pyo3/src/lib.rs: use parking_lot::Mutex as FfiMutex;

Why not create a new repo

Per operator constraint: 'this process should NOT create swathes of new repos NOR dump tars or other unsemantic restores/integrations into a new repo'. ffi_utils is one type alias; promoting it to a crate would be over-engineering.

Stats

2 files, 2 insertions(+), 2 deletions(-)


CodeAnt-AI Description

Remove the unavailable shared dependency from the Python harness

What Changed

  • The Python harness now uses its existing mutex dependency directly instead of relying on the deleted shared ffi_utils package
  • The harness can build without a local dependency on the removed phenotype-shared repository
  • Cache synchronization behavior remains unchanged

Impact

✅ Restored Python harness builds
✅ Fewer dependency resolution failures
✅ Unchanged cache behavior

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

The `ffi_utils` crate from KooshaPari/phenotype-shared was a trivial
re-export of `parking_lot::Mutex as FfiMutex`. Now that phenotype-shared
is deleted, this 3-line crate is inlined into helios-cli directly.

Change:
  - crates/harness_pyo3/Cargo.toml: drop ffi_utils path dep
  - crates/harness_pyo3/src/lib.rs: use parking_lot::Mutex as FfiMutex

Why not create a new crate:
  Per operator constraint: 'this process should NOT create swathes of
  new repos NOR dump tars or other unsemantic restores/integrations
  into a new repo'. ffi_utils has 1 type alias; promoting it to a new
  crate would be over-engineering.

Refs:
- KooshaPari/phenotype-shared (deleted 2026-08-09)
- plans/dockets/N00-phenotype-sdk-decomp-operator-summary.md

Stats: 2 files, 2 insertions(+), 2 deletions(-)
Copilot AI lite review requested due to automatic review settings August 10, 2026 04:48
@codeant-ai

codeant-ai Bot commented Aug 10, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 82fcda8 Aug 10, 2026 · 04:48 04:51

@codeant-ai

codeant-ai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Aug 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sonarqubecloud

Copy link
Copy Markdown

@kilo-code-bot

kilo-code-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • crates/harness_pyo3/Cargo.toml
  • crates/harness_pyo3/src/lib.rs

Reviewed by step-3.7-flash · Input: 45.9K · Output: 8.2K · Cached: 228.5K

@KooshaPari
KooshaPari merged commit 1018986 into main Aug 10, 2026
29 of 33 checks passed
@KooshaPari
KooshaPari deleted the fix/inline-ffi_utils-to-parking_lot branch August 10, 2026 06:34
@KooshaPari
KooshaPari restored the fix/inline-ffi_utils-to-parking_lot branch August 11, 2026 07:02
@KooshaPari
KooshaPari deleted the fix/inline-ffi_utils-to-parking_lot branch August 13, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants