chore(deps): inline ffi_utils to parking_lot (phenotype-shared deleted) - #627
Merged
Conversation
The `ffi_utils` crate from KooshaPari/phenotype-shared was a trivial re-export of `parking_lot::Mutex as FfiMutex`. Now that phenotype-shared is deleted, this 3-line crate is inlined into helios-cli directly. Change: - crates/harness_pyo3/Cargo.toml: drop ffi_utils path dep - crates/harness_pyo3/src/lib.rs: use parking_lot::Mutex as FfiMutex Why not create a new crate: Per operator constraint: 'this process should NOT create swathes of new repos NOR dump tars or other unsemantic restores/integrations into a new repo'. ffi_utils has 1 type alias; promoting it to a new crate would be over-engineering. Refs: - KooshaPari/phenotype-shared (deleted 2026-08-09) - plans/dockets/N00-phenotype-sdk-decomp-operator-summary.md Stats: 2 files, 2 insertions(+), 2 deletions(-)
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by step-3.7-flash · Input: 45.9K · Output: 8.2K · Cached: 228.5K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



User description
Summary
Inline the trivial
ffi_utilscrate (3 lines: re-export ofparking_lot::Mutex as FfiMutex) into helios-cli directly. phenotype-shared is deleted.Change
crates/harness_pyo3/Cargo.toml: dropffi_utilspath depcrates/harness_pyo3/src/lib.rs:use parking_lot::Mutex as FfiMutex;Why not create a new repo
Per operator constraint: 'this process should NOT create swathes of new repos NOR dump tars or other unsemantic restores/integrations into a new repo'. ffi_utils is one type alias; promoting it to a crate would be over-engineering.
Stats
2 files, 2 insertions(+), 2 deletions(-)
CodeAnt-AI Description
Remove the unavailable shared dependency from the Python harness
What Changed
ffi_utilspackagephenotype-sharedrepositoryImpact
✅ Restored Python harness builds✅ Fewer dependency resolution failures✅ Unchanged cache behavior💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.