fix(ci): restore working trunk config on main - #629
Conversation
PR #628 emptied .trunk/trunk.yaml (main currently has a 0-byte file), so Trunk Check has failed on main since. Restore the schema-0.1 config that validated GREEN on CI (run 31551719038): trunk plugin ref v1.11.0 (fixes taplo single-file download and ruff --output-format), pinned linter versions (actionlint, black, clippy 1.88.0, eslint, golangci-lint, mypy, prettier, ruff 0.16.2, rustfmt 1.88.0, shellcheck, taplo, yamllint), plus .trunk/.gitignore for the runtime dirs. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2eb20d4c50
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - actionlint@1.7.8 | ||
| - black@25.9.0 | ||
| - clippy@1.88.0 | ||
| - eslint@8.10.0 |
There was a problem hiding this comment.
Align Trunk ESLint with the SDK config
In PRs that touch sdk/typescript/**/*.ts, this enabled linter makes Trunk run its managed eslint@8.10.0 from the checkout-only trunk-check workflow, but the TypeScript SDK is configured for flat-config ESLint 9 (eslint.config.js imports eslint/config, @eslint/js, typescript-eslint, and eslint-plugin-node-import, and package.json pins eslint to ^9.36.0). That mismatch means the Trunk Check job will fail before linting the changed TypeScript files; either pin Trunk to the same package-supported ESLint 9 setup and install/resolve the SDK deps, or keep ESLint out of Trunk for this repo slice.
Useful? React with 👍 / 👎.
Code Review SummaryStatus: 1 Unresolved Issue | Recommendation: Request Changes Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 49.8K · Output: 15.3K · Cached: 447.4K |



User description
Problem
Main's
.trunk/trunk.yamlis a 0-byte file (emptied by #628), so Trunk Check has failed on main (latest: failure in 24s). The working config that validated GREEN on CI (run 31551719038) only exists on the v8-canary branch.Fix
Restore the schema-0.1 config as byte-identical to the CI-GREEN state:
rename_single_fileand ruff's--output-format json).trunk/.gitignoreso the runtime dirs never get committedValidation
Local
trunk checkon 29 files: no new issues. This exact config passed the CI Trunk Check gate at cc4b919.CodeAnt-AI Description
Restore reliable CI linting and formatting checks
What Changed
Impact
✅ Working CI lint checks✅ Consistent formatting across environments✅ Earlier detection of lint issues before push💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.