Skip to content

fix(ci): restore working trunk config on main - #629

Merged
KooshaPari merged 1 commit into
mainfrom
fix/trunk-config-restore
Aug 14, 2026
Merged

fix(ci): restore working trunk config on main#629
KooshaPari merged 1 commit into
mainfrom
fix/trunk-config-restore

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 14, 2026

Copy link
Copy Markdown
Owner

User description

Problem

Main's .trunk/trunk.yaml is a 0-byte file (emptied by #628), so Trunk Check has failed on main (latest: failure in 24s). The working config that validated GREEN on CI (run 31551719038) only exists on the v8-canary branch.

Fix

Restore the schema-0.1 config as byte-identical to the CI-GREEN state:

  • plugin ref v1.11.0 (fixes taplo's bare-.gz single-binary download via rename_single_file and ruff's --output-format json)
  • pinned linter versions: actionlint@1.7.8, black@25.9.0, clippy@1.88.0, eslint@8.10.0, golangci-lint@2.6.1, mypy@2.1.0, prettier@3.6.2, ruff@0.16.2, rustfmt@1.88.0, shellcheck@0.10.0, taplo@0.10.0, yamllint@1.37.1
  • .trunk/.gitignore so the runtime dirs never get committed

Validation

Local trunk check on 29 files: no new issues. This exact config passed the CI Trunk Check gate at cc4b919.


CodeAnt-AI Description

Restore reliable CI linting and formatting checks

What Changed

  • Restored the repository’s Trunk configuration so CI checks run instead of failing with an empty configuration
  • Pinned the CLI and linting tools to known versions for consistent results across environments
  • Restored repository-specific formatting and Rust lint rules, including 100-character Black formatting and warning-free Clippy checks
  • Excluded workflow files from conflicting Prettier and Yamllint checks while keeping them covered by Actionlint
  • Added a pre-push check to catch linting issues before code is pushed

Impact

✅ Working CI lint checks
✅ Consistent formatting across environments
✅ Earlier detection of lint issues before push

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

PR #628 emptied .trunk/trunk.yaml (main currently has a 0-byte file),
so Trunk Check has failed on main since. Restore the schema-0.1 config
that validated GREEN on CI (run 31551719038): trunk plugin ref v1.11.0
(fixes taplo single-file download and ruff --output-format), pinned
linter versions (actionlint, black, clippy 1.88.0, eslint, golangci-lint,
mypy, prettier, ruff 0.16.2, rustfmt 1.88.0, shellcheck, taplo,
yamllint), plus .trunk/.gitignore for the runtime dirs.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings August 14, 2026 04:10
@codeant-ai

codeant-ai Bot commented Aug 14, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 2eb20d4 Aug 14, 2026 · 04:10 04:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai

codeant-ai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:M This PR changes 30-99 lines, ignoring generated files label Aug 14, 2026
@sonarqubecloud

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2eb20d4c50

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .trunk/trunk.yaml
- actionlint@1.7.8
- black@25.9.0
- clippy@1.88.0
- eslint@8.10.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align Trunk ESLint with the SDK config

In PRs that touch sdk/typescript/**/*.ts, this enabled linter makes Trunk run its managed eslint@8.10.0 from the checkout-only trunk-check workflow, but the TypeScript SDK is configured for flat-config ESLint 9 (eslint.config.js imports eslint/config, @eslint/js, typescript-eslint, and eslint-plugin-node-import, and package.json pins eslint to ^9.36.0). That mismatch means the Trunk Check job will fail before linting the changed TypeScript files; either pin Trunk to the same package-supported ESLint 9 setup and install/resolve the SDK deps, or keep ESLint out of Trunk for this repo slice.

Useful? React with 👍 / 👎.

@kilo-code-bot

kilo-code-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 1 Unresolved Issue | Recommendation: Request Changes

Overview

Severity Count
CRITICAL 1
Issue Details (click to expand)

CRITICAL

File Line Issue
.trunk/trunk.yaml 61 ESLint 8.10.0 incompatible with SDK's ESLint 9 flat config
Files Reviewed (2 files)
  • .trunk/trunk.yaml
  • .trunk/.gitignore

Fix these issues in Kilo Cloud


Reviewed by step-3.7-flash · Input: 49.8K · Output: 15.3K · Cached: 447.4K

@KooshaPari
KooshaPari merged commit 8cbd6a6 into main Aug 14, 2026
20 of 23 checks passed
@KooshaPari
KooshaPari deleted the fix/trunk-config-restore branch August 14, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants