refactor: simplify zipOrAccumulateNonEmptySet implementation #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the
EitherNes
utility in thecore
module by removing unnecessary contracts and refactoring thezipOrAccumulateNonEmptySet
function to leverage an existingzipOrAccumulate
implementation. Additionally, unused imports and internal properties have been removed to clean up the codebase.Refactoring and simplification:
core/src/main/java/com/hoc/flowmvi/core/EitherNes.kt
: Refactored thezipOrAccumulateNonEmptySet
function to delegate to thezipOrAccumulate
function, removing the custom implementation and reducing redundancy. This change also eliminates the need for thecount
extension property and theExperimentalContracts
annotation.Code cleanup:
core/src/main/java/com/hoc/flowmvi/core/EitherNes.kt
: Removed unused imports, includingtoNonEmptySetOrNull
,ExperimentalContracts
,InvocationKind
, andcontract
, to streamline the file.