Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add Uri/Url Type to Kotlin Standard Library #415

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

iseki0
Copy link
Contributor

@iseki0 iseki0 commented Mar 8, 2025

No description provided.

@gildor
Copy link
Contributor

gildor commented Mar 10, 2025

It would be great to have it in the standard library. But I feel that it must be both URI and URL, it's very useful to know that it's an actual URL and it mostly should be used everywhere instead of more generic URI which rarely used correctly

@iseki0
Copy link
Contributor Author

iseki0 commented Mar 10, 2025

OK, maybe we can add both Uri and Url into the stdlib

@iseki0
Copy link
Contributor Author

iseki0 commented Mar 10, 2025

@gildor What do you think about add IP address types? Since the URI/URL might use IP address in the authority segment.

@iseki0 iseki0 changed the title Proposal: Add URI Type to Kotlin Standard Library Proposal: Add Uri/Url Type to Kotlin Standard Library Mar 10, 2025
@gildor
Copy link
Contributor

gildor commented Mar 11, 2025

@iseki0 I personally never had use case for this, but I'm curious about support in other languages. Distinguish between ipv4/v6 could be useful, but I feel that it's not a job for URL/uri to give IP information, but maybe I'm wrong

@iseki0
Copy link
Contributor Author

iseki0 commented Mar 11, 2025

Distinguish between ipv4/v6 could be useful, but I feel that it's not a job for URL/uri to give IP information

Maybe you're right, it should be in network library

@iseki0 iseki0 requested a review from gildor March 14, 2025 20:29
@iseki0
Copy link
Contributor Author

iseki0 commented Mar 14, 2025

@gildor Thank you for your reviewing, in the past serval days, I added more content into the proposal. Please review it again.
Thank you

@iseki0
Copy link
Contributor Author

iseki0 commented Mar 14, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants