New gallery UI implementation #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
commented
Apr 2, 2025
| @@ -30,8 +30,14 @@ dependencyResolutionManagement { | |||
| } | |||
| } | |||
|
|
|||
| plugins { | |||
| id("org.gradle.toolchains.foojay-resolver-convention") version "0.9.0" | |||
There was a problem hiding this comment.
added for hot-reload on jvm/deskop: https://github.com/JetBrains/compose-hot-reload
eymar
commented
Apr 2, 2025
...gradle-plugin/src/main/kotlin/org/jetbrains/compose/storytale/plugin/JsMultiplatformTasks.kt
Outdated
Show resolved
Hide resolved
whitescent
reviewed
Apr 3, 2025
...ery/src/commonMain/kotlin/org/jetbrains/compose/storytale/gallery/material3/FullStoryView.kt
Outdated
Show resolved
Hide resolved
… state in Story code
JSMonk
reviewed
Apr 13, 2025
| @@ -0,0 +1,122 @@ | |||
| import org.jetbrains.compose.reload.ComposeHotRun | |||
There was a problem hiding this comment.
I have a small question related to this module. We have the example one, which contains an example of the demo. Was it intentional to create a new one instead of re-using the example?
JSMonk
reviewed
Apr 13, 2025
| operator fun provideDelegate(thisRef: Any?, property: KProperty<*>) = also { | ||
| story.nameToParameterMapping.getOrPut(property.name) { | ||
| StoryParameter(property.name, type) { remember { mutableStateOf(defaultValue) } } | ||
| StoryParameter(property.name, type) { mutableStateOf(defaultValue) } |
There was a problem hiding this comment.
I'd like to know (just for my education with Compose). Why don't we need remember here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
./gradlew :gallery-demo:wasmJsBrowserDevelopmentRun