Skip to content

Added a columnOf types test#1729

Open
AndreiKingsley wants to merge 3 commits intomasterfrom
columnOf_types
Open

Added a columnOf types test#1729
AndreiKingsley wants to merge 3 commits intomasterfrom
columnOf_types

Conversation

@AndreiKingsley
Copy link
Collaborator

Added a small test that checks #678 and #679

Copy link
Collaborator

@Jolanrensen Jolanrensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice this was fixed on Kotlin's side! :) I suppose we could now also simplify the Array helpers in TypeUtils.kt, like:

internal val KType.isPrimitiveArray: Boolean

@AndreiKingsley
Copy link
Collaborator Author

AndreiKingsley commented Mar 12, 2026

@Jolanrensen I will fix this in this PR then!

Could you please tell me what is supposed to be fixed here?

// https://github.com/Kotlin/dataframe/issues/678

upd: never mind, understand that

@AndreiKingsley
Copy link
Collaborator Author

AndreiKingsley commented Mar 14, 2026

Removed all workarounds related to #678 and #679 and cover those methods with tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants