Skip to content

Added support for BIGINT UNSIGNED type in MySQL and MariaDB DBTypes#1735

Open
AndreiKingsley wants to merge 5 commits intomasterfrom
fix_jdbc_types
Open

Added support for BIGINT UNSIGNED type in MySQL and MariaDB DBTypes#1735
AndreiKingsley wants to merge 5 commits intomasterfrom
fix_jdbc_types

Conversation

@AndreiKingsley
Copy link
Collaborator

Fixes #762.

@Jolanrensen
Copy link
Collaborator

Jolanrensen commented Mar 10, 2026

could you add tests for this specific fix? :)

(the build should not have failed, I'll rerun)
(okay, maybe rebase on master, I've limited the maven logs, they were getting way too large)

@AndreiKingsley
Copy link
Collaborator Author

AndreiKingsley commented Mar 11, 2026

@Jolanrensen added tests as an initiating of #1736.

@Jolanrensen
Copy link
Collaborator

@AndreiKingsley that's good :) though, I would also recommend running a test with the actual database, like here https://github.com/Kotlin/dataframe/blob/c3742a95684d53a813d978a3c895090ba684c46e/dataframe-jdbc/src/test/kotlin/org/jetbrains/kotlinx/dataframe/io/local/mysqlTest.kt (though, you'd need to set up a local database for that. Just ask Junie to do that for you ;P, I think @zaleslaw would appreciate it :) )

@AndreiKingsley
Copy link
Collaborator Author

@Jolanrensen , added BIGINT UNSIGNED columns to Genereal MariaDB / MySQL tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataFrame fails on simple actions with casting BigInteger to Long

2 participants