Skip to content

Added a method for handling extension property exceptions#1896

Merged
AndreiKingsley merged 2 commits into
masterfrom
ep_exceptions_handling
Jun 12, 2026
Merged

Added a method for handling extension property exceptions#1896
AndreiKingsley merged 2 commits into
masterfrom
ep_exceptions_handling

Conversation

@AndreiKingsley

Copy link
Copy Markdown
Collaborator

Helps #1742.

This method should be used in the extension property generation logic inside the Compiler Plugin.

@AndreiKingsley

Copy link
Copy Markdown
Collaborator Author

@Jolanrensen @koperagen should we mark such method (that shouldn't be used by a regular user but should be public) with some annotation?

public fun handleExtensionPropertyException(e: Exception, columnName: String) {
val msg = when (e) {
is IllegalArgumentException ->
"Column not found exception in the generated DataFrame extension property '$columnName': ${e.localizedMessage}. See $$TROUBLESHOOTING_LINK for more information."

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the $ signs again ;P

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jolanrensen

Copy link
Copy Markdown
Collaborator

@AndreiKingsley hmm, we have @RequiredByIntellijPlugin, but that is only used for public functions too. For the compiler plugin we usually just have obscure public functions.

I'm not sure whether we already tried something like:

  • internal with suppressing all warnings (but we know how that can break stuff now)
  • Deprecated HIDDEN and suppressing warnings?
  • OptIn required?

@AndreiKingsley

Copy link
Copy Markdown
Collaborator Author

Ok, let's then first finalize the standard approach; for now, I’ll just add this without any annotation.

@AndreiKingsley AndreiKingsley merged commit 0a0d89b into master Jun 12, 2026
5 checks passed
@AndreiKingsley AndreiKingsley deleted the ep_exceptions_handling branch June 12, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants