Skip to content

Possible resolution of KT-68543 (Add explanation about declaration checks of variant type parameters) #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

MarkTheHopeful
Copy link

Rough description of how it should work, text is to be altered

@MarkTheHopeful MarkTheHopeful changed the title First draft of new variance description Possible resolution of KT-68543 (Add explanation about declaration checks of variant type parameters) Mar 14, 2025
@MarkTheHopeful
Copy link
Author

Currently, inside code snippets in the added part, some math ($\otimes$) is not rendered properly and I haven't figured out yet how to fix that.

@ice-phoenix
Copy link
Contributor

Try looking at the following example, thanks!

Copy link
Contributor

@ice-phoenix ice-phoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks quite good!

@MarkTheHopeful
Copy link
Author

MarkTheHopeful commented Mar 18, 2025

Try looking at the following example, thanks!

Not exactly was I had in mind, unfortunately;
In this example we switch directly to math mode and using verbatim, which is fine if used standalone, but may look out of place if put directly into the code snippet (lines around 1909)

UPD: I found an example of proper unicode usage in the spec ( in CFGs), so there is a way to set up a character to work with latex... Now I just need to find, how it's done here.

UPD2: Found; Fixed.

@MarkTheHopeful MarkTheHopeful marked this pull request as ready for review April 1, 2025 17:27
@ice-phoenix
Copy link
Contributor

LGTM, thanks a lot for the fixes! Could you squash and rebase?

@ice-phoenix ice-phoenix merged commit e90a225 into Kotlin:develop Apr 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants