Skip to content

Increase Lincheck version to 3.0 - #4467

Open
ndkoval wants to merge 1 commit into
developfrom
lincheck-version-3.0
Open

Increase Lincheck version to 3.0#4467
ndkoval wants to merge 1 commit into
developfrom
lincheck-version-3.0

Conversation

@ndkoval

@ndkoval ndkoval commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@ndkoval
ndkoval requested a review from dkhalanskyjb July 1, 2025 09:37
Signed-off-by: Nikita Koval <ndkoval@ya.ru>
@ndkoval
ndkoval force-pushed the lincheck-version-3.0 branch from 4687658 to cb01599 Compare July 1, 2025 09:39

@dkhalanskyjb dkhalanskyjb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alarming that the CI consistently takes about ~20-30 minutes longer with this change. What could be the reason?

@@ -252,6 +252,7 @@ kover {

// lincheck has NPE error on `ManagedStrategyStateHolder` class
excludedClasses.addAll("org.jetbrains.kotlinx.lincheck.*")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historical note: https://repo.maven.apache.org/maven2/org/jetbrains/lincheck/lincheck/3.0/lincheck-3.0.jar does contain classes in both org.jetbrains.lincheck and org.jetbrains.kotlinx.lincheck packages, so keeping these exclusions is intentional.

open fun isEmpty() = c.isEmpty

@StateRepresentation
fun state() = (c as? BufferedChannel<*>)?.toStringDebug() ?: c.toString()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, should we also remove toStringDebug() itself? If not, then at least the comment to that function should be updated.

@dkhalanskyjb

Copy link
Copy Markdown
Collaborator

Also, on my machine, ./gradlew clean check -Pstress=true fails. The following tests have problems:

    Buffered1BroadcastChannelLincheckTest. modelCheckingTest[jvm]
    Buffered1ChannelLincheckTest. modelCheckingTest[jvm]
    Buffered2BroadcastChannelLincheckTest. modelCheckingTest[jvm]
    Buffered2ChannelLincheckTest. modelCheckingTest[jvm]
    ConflatedBroadcastChannelLincheckTest. modelCheckingTest[jvm]
    ConflatedChannelLincheckTest. modelCheckingTest[jvm]
    RendezvousChannelLincheckTest. modelCheckingTest[jvm]
    Semaphore1LincheckTest. modelCheckingTest[jvm]
    Semaphore2LincheckTest. modelCheckingTest[jvm]
    UnlimitedChannelLincheckTest. modelCheckingTest[jvm]

One example of a problem: https://gist.github.com/dkhalanskyjb/528602e1adfdb402b14bcdef11a5ad44

@dkhalanskyjb

Copy link
Copy Markdown
Collaborator

Sorry, disregard my latest message: the same happens on develop as well. I think I haven't run clean check -Pstress=true for some time, and something may have regressed in my configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants