Enhance CoroutineDispatcher.invoke with contract - #4554
Open
LouisCAD wants to merge 1 commit into
Open
Conversation
Add contract to CoroutineDispatcher.invoke operator, to allow initializing read-only properties declared before, from inside the passed block. https://youtrack.jetbrains.com/issue/KT-32313/Support-contracts-for-operator-functions This commit also improve the KDoc to show a usage example, and explain why it's less error-prone than withContext.
qwwdfsad
self-requested a review
November 7, 2025 18:16
qwwdfsad
reviewed
Nov 7, 2025
qwwdfsad
left a comment
qwwdfsad
left a comment
Member
There was a problem hiding this comment.
Thanks! Could you please also add a test for that? (i.e. like RunBlocking.testContract)
| * | ||
| * Example usage: | ||
| * ``` | ||
| * Dispatchers.IO { someFile.exists() } // Checking the file system is blocking I/O. |
Member
There was a problem hiding this comment.
Suggested change
| * Dispatchers.IO { someFile.exists() } // Checking the file system is blocking I/O. | |
| * Dispatchers.IO { | |
| * someFile.exists() // Checking the file system is blocking I/O | |
| * } |
Collaborator
|
Let's reach a conclusion on #4199 first before going through with this, so that we don't risk doing extra work that will ultimately not be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add contract to CoroutineDispatcher.invoke operator, to allow initializing read-only properties declared before, from inside the passed block.
https://youtrack.jetbrains.com/issue/KT-32313/Support-contracts-for-operator-functions
This commit also improve the KDoc to show a usage example, and explain why it's less error-prone than withContext.