Skip to content

Optimize attaching the debug probes #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkhalanskyjb wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Optimize attaching the debug probes #4619

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57c7902
Optimize attaching the debug probes
dkhalanskyjb Feb 17, 2026
fb09810
Move the top-level cache variables into the companion object
dkhalanskyjb Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 22 additions & 15 deletions kotlinx-coroutines-debug/src/Attach.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,30 @@ internal class ByteBuddyDynamicAttach : Function1<Boolean, Unit> {

private fun attach() {
ByteBuddyAgent.install(ByteBuddyAgent.AttachmentProvider.ForEmulatedAttachment.INSTANCE)
val cl = Class.forName("kotlin.coroutines.jvm.internal.DebugProbesKt")
val cl2 = Class.forName("kotlinx.coroutines.debug.internal.DebugProbesKt")

ByteBuddy()
.redefine(cl2)
.name(cl.name)
.make()
.load(cl.classLoader, ClassReloadingStrategy.fromInstalledAgent())
dynamicTypeWithProbes.load(targetClassLoader, ClassReloadingStrategy.fromInstalledAgent())
}

private fun detach() {
val cl = Class.forName("kotlin.coroutines.jvm.internal.DebugProbesKt")
val cl2 = Class.forName("kotlinx.coroutines.debug.NoOpProbesKt")
ByteBuddy()
.redefine(cl2)
.name(cl.name)
.make()
.load(cl.classLoader, ClassReloadingStrategy.fromInstalledAgent())
dynamicTypeWithoutProbes.load(targetClassLoader, ClassReloadingStrategy.fromInstalledAgent())
}
}

private val targetClassLoader = Class.forName(classNameToOverride).classLoader

@qwwdfsad qwwdfsad Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things probably belong to ByteBuddyDynamicAttach's companion, potentially as @JvmStatic encapsulation-wise.

Beware of targetClassLoader computed eagerly in that case though


private const val classNameToOverride = "kotlin.coroutines.jvm.internal.DebugProbesKt"

private val dynamicTypeWithProbes by lazy {
val classWithProbes = Class.forName("kotlinx.coroutines.debug.internal.DebugProbesKt")
ByteBuddy()
.redefine(classWithProbes)
.name(classNameToOverride)
.make()
}

private val dynamicTypeWithoutProbes by lazy {
val classWithoutProbes = Class.forName("kotlinx.coroutines.debug.NoOpProbesKt")
ByteBuddy()
.redefine(classWithoutProbes)
.name(classNameToOverride)
.make()
}