Migrate to DGPv2 #3005
Open
Migrate to DGPv2 #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyoleg
commented
May 16, 2025
| } | ||
| dokka.dokkaSourceSets.configureEach { | ||
| externalDocumentationLinks.register("kotlinx-io") { | ||
| url("https://kotlinlang.org/api/kotlinx-io/") |
There was a problem hiding this comment.
JIC: old URL is not accessible anymore
whyoleg
commented
May 16, 2025
| @@ -52,11 +52,4 @@ kotlin { | |||
| } | |||
| } | |||
|
|
|||
| // This task should be disabled because of no need to build and publish intermediate JsWasm sourceset | |||
| tasks.whenTaskAdded { | |||
There was a problem hiding this comment.
This workaround is not needed, locally build and publish tasks works find without it, but it caused some issues locally at my side.
I can revert it, if you know the reason why it's needed
whyoleg
commented
May 16, 2025
|
|
||
| sourceLink { | ||
| localDirectory.set(rootDir) | ||
| perPackageOption { |
There was a problem hiding this comment.
Previously, there were multiple perPackageOption - most of them are obsolete or separate configurations for internal package. So, obsolete were removed and internal are handled by one regex now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to new Dokka Gradle Plugin (migration guide)
Because of the Gradle task name change, the kotlinlang deploy configuration should also be updated.
Related: JetBrains/kotlin-web-site#4851