Shadow 9.0.2 - #555
Closed
Goooler wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
As there is a bug of diffing large JARs from JakeWharton/diffuse#325, I haven't diffed the artifacts between upgrading or not. |
Contributor
Author
|
The format validation failure is due to f8fcec6, not related to my changes. |
hick209
reviewed
Aug 26, 2025
Comment on lines
+114
to
+115
| duplicatesStrategy = DuplicatesStrategy.EXCLUDE | ||
| failOnDuplicateEntries = true |
Collaborator
There was a problem hiding this comment.
What's the rationale behind adding those 2 lines here?
Contributor
Author
There was a problem hiding this comment.
Exclude is the default strategy. But I suggested declaring this property explicitly in configuration at https://github.com/GradleUp/shadow/releases/tag/9.0.1
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D81132131. |
Contributor
|
@cortinico merged this pull request in bb6ad1e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.