Backport 'Fix for PDF texts not being selectable'#240
Open
malthe wants to merge 2 commits intoKozea:1.0.xfrom
Open
Backport 'Fix for PDF texts not being selectable'#240malthe wants to merge 2 commits intoKozea:1.0.xfrom
malthe wants to merge 2 commits intoKozea:1.0.xfrom
Conversation
Co-authored-by: aziesemer <aziesemer@users.noreply.github.com>
Contributor
|
There was a bug in this version because I was not copying save_cursor by value. See: |
Member
|
Hello! I can merge this pull request when tests are fixed, but I'd like to avoid a new 1.x version: Python 2 will be dead at the end of the year, it's probably time to port old code to Python 3 instead of backporting new code to Python 2 😇. |
aziesemer
reviewed
May 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: aziesemer aziesemer@users.noreply.github.com