Drop zxcvbn password dependency#163
Open
alexandreNoens wants to merge 1 commit into
Open
Conversation
zxcvbn adds a large embedded dictionary to formol.js. For issue #121, this dependency represented about 823 kB and a significant part of the client bundle. Replace zxcvbn scoring in PasswordStrengthField with an internal password-strength utility based on: - length bounds (min and max) - repeated character detection - sequential and keyboard pattern detection - email-like input detection - entropy thresholds mapped to scores 0..4 Update defaults to minLength=8 and maxLength=64, remove userInputs from the scoring path, and add focused tests for both the new helper and the password-strength field behavior. Side effects: password scores can differ from previous zxcvbn results, especially for edge cases, but validation flow is preserved while reducing bundle size. Resolves: #121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zxcvbn adds a large embedded dictionary to formol.js. For issue #121, this dependency represented about 823 kB and a significant part of the client bundle.
Replace zxcvbn scoring in PasswordStrengthField with an internal password-strength utility based on:
Update defaults to minLength=8 and maxLength=64, remove userInputs from the scoring path, and add focused tests for both the new helper and the password-strength field behavior.
Side effects: password scores can differ from previous zxcvbn results, especially for edge cases, but validation flow is preserved while reducing bundle size.
Close #121