Skip to content

Conversation

@loumalouomega
Copy link
Member

📝 Description

Move BaseSocketCommunication destructor to header to fix C++20 compilation. See for example: https://github.com/KratosMultiphysics/Kratos/actions/runs/18677406599/job/53257969885?pr=13549

🆕 Changelog

Copy link
Contributor

@matekelemen matekelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really isn't necessary. The problem is that the template parameter is specified in the destructor's name as well (which has already been fixed).

@matekelemen
Copy link
Contributor

The main issue is that I started an update to CoSim but didn't have time to finish it yet.

Check these WIP pull requests:

@loumalouomega
Copy link
Member Author

The main issue is that I started an update to CoSim but didn't have time to finish it yet.

Check these WIP pull requests:

* [[CoSim][External] Update CoSimIO Kratos#13374](https://github.com/KratosMultiphysics/Kratos/pull/13374)

* [Set install directories depending on target type #374](https://github.com/KratosMultiphysics/CoSimIO/pull/374)

Ah, OK, sorry for the noise

@loumalouomega loumalouomega deleted the fix-c++20-compilation branch October 29, 2025 15:00
@loumalouomega
Copy link
Member Author

Are you sure this is fixed? https://github.com/KratosMultiphysics/Kratos/actions/runs/18912407359/job/53987835109, or do we need to do something in Kratos side?

@loumalouomega
Copy link
Member Author

Ah, Okay, is hardcopied, it is not a subdmoule. My bad.

@matekelemen
Copy link
Contributor

I'd be all for submodules but your boss vehemently opposes the idea. None of Kratos' dependencies are submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants