[MAPPING] Adding a new RBF Utility inside the Mapping Application #13958
+257
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbucher
reviewed
Nov 7, 2025
Member
philbucher
left a comment
philbucher
left a comment
There was a problem hiding this comment.
LGTM
@matekelemen any comments?
Member
There was a problem hiding this comment.
some documentation would be nice
Member
|
TBH, I think we had the chance to implement more shapes to the RBF utilities in the core. I mean, by closing the other PR, and thus closing the discussion, to open this one you are IMO taking the quick (and suboptimal) path to merge. Nevertheless, this is not sufficient reason to block it. |
Contributor
Author
|
In my opinion, it makes sense to have this simple Interface in the MappingApplication for the need we have. As I said before, we are using this utility just as an Interface to evaluate RBFs, whereas the implementation in the core is doing the RBF Interpolation |
philbucher
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a new utility called
RadialBasisFunctionUtilitiesinside theMappingApplicationto include several additional Radial Basis Function (RBF) formulations commonly used for mapping in multi-physics applications (e.g., FSI coupling).Related PRs
#13917
#13934
FYI @rubenzorrilla, I will not modify the implementation in the core