set application name in connection string #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burgyn
requested changes
Feb 6, 2025
| { | ||
| var builder = new SqlConnectionStringBuilder(connectionString); | ||
|
|
||
| if (string.IsNullOrEmpty(builder.ApplicationName) && !string.IsNullOrEmpty(applicationName)) |
There was a problem hiding this comment.
Ja by som tú podmienku dal na začiatku. Načo parsovať a vytvárať SqlConnectionStringBuilder, keď vlastne sa to vôbec možno nepoužije?
|
Pull request uzatváram. Riešenie v PR nie je dobré, pretože application name by sa pridal do connection stringu len v prípade, že korm databáza sa konfiguruje pomocou extension metódy , v ktorej sa volá metóda GetKormConnectionString. Korm databáza sa dá nakonfigurovať aj pomocou iných extension metód, prípadne úplne bez použitia extension metód z Kros.KORM.Extensions.Asp. Pridanie názvu aplikácie by sa teda malo robiť priamo v Kros.Korm knižnici kde sa používa connection string z KormConnectionSettings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set application name in connection string if connection string does not already contain application name parameter.