Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to latest patch of golang 1.22 #1207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

move to latest patch of golang 1.22 #1207

wants to merge 1 commit into from

Conversation

maleck13
Copy link
Collaborator

Signed-off-by: craig [email protected]

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

@maleck13 maleck13 requested a review from a team as a code owner March 14, 2025 08:29
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.50%. Comparing base (f5a0df3) to head (25c17ad).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   83.57%   83.50%   -0.08%     
==========================================
  Files          82       82              
  Lines        7117     7117              
==========================================
- Hits         5948     5943       -5     
- Misses        937      944       +7     
+ Partials      232      230       -2     
Flag Coverage Δ
bare-k8s-integration 23.48% <ø> (-0.20%) ⬇️
controllers-integration 74.28% <ø> (+0.12%) ⬆️
envoygateway-integration 41.51% <ø> (+0.11%) ⬆️
gatewayapi-integration 20.11% <ø> (+0.24%) ⬆️
istio-integration 44.06% <ø> (-0.18%) ⬇️
unit 19.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 90.78% <ø> (ø)
api/v1beta2 (u) ∅ <ø> (∅)
pkg/common (u) ∅ <ø> (∅)
pkg/istio (u) 62.06% <ø> (ø)
pkg/log (u) 93.18% <ø> (ø)
pkg/reconcilers (u) 24.50% <ø> (ø)
pkg/rlptools (u) ∅ <ø> (∅)
controllers (i) 86.64% <ø> (+0.02%) ⬆️

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@eguzki eguzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up:

latest Go Toolset for UBI 9 is 1.22.9. https://catalog.redhat.com/software/containers/ubi9/go-toolset/61e5c00b4ec9945c18787690

This go directive sets a minimum. Go toolchains refuse to use modules declaring newer Go versions. https://go.dev/doc/modules/gomod-ref#go

@maleck13
Copy link
Collaborator Author

Thanks @eguzki will move it back so 👍

Signed-off-by: craig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants