fix(openshift): add EnvoyFilter CRD stub for OCP ingress without Service Mesh#811
fix(openshift): add EnvoyFilter CRD stub for OCP ingress without Service Mesh#811matzew wants to merge 1 commit intoKuadrant:mainfrom
Conversation
…ice Mesh The mcp-gateway controller watches the EnvoyFilter CRD from networking.istio.io/v1alpha3 at startup. When deploying with USE_OCP_INGRESS=true (no Service Mesh), this CRD does not exist and the controller crashes in a loop: no matches for kind "EnvoyFilter" in version "networking.istio.io/v1alpha3" Add a minimal stub CRD to the ocp-ingress kustomize overlay so the controller cache can sync without requiring a full Service Mesh install. Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughIntroduces a new EnvoyFilter CustomResourceDefinition for Istio networking in the OpenShift kustomize configuration, marking it as a namespaced resource with v1alpha3 version. The CRD is registered in the base kustomization resources. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
When you say no mesh can you expand? Is it still the Istio control plane that is managing the gateways? Without the presence of an EnvoyFilter how is traffic reaching the ext_proc |
The
mcp-gatewaycontroller watches theEnvoyFilterCRD fromnetworking.istio.io/v1alpha3at startup. When deploying withUSE_OCP_INGRESS=true(no Service Mesh), this CRD does not exist and the controller crashes in a loop:This adds a minimal stub CRD to the ocp-ingress kustomize overlay so the controller cache can sync without requiring a full Service Mesh install.
Summary by CodeRabbit